Bump versions and make CI work #2
Conversation
Signed-off-by: gatecat <gatecat@ds0.me>
| @@ -1,7 +1,5 @@ | |||
| on: | |||
| push: | |||
| branches: | |||
There was a problem hiding this comment.
What's the reasoning here?
There was a problem hiding this comment.
oh, this was my debugging GH actions not working
| python: "3.11" | ||
| - os: macos-13 | ||
| python: "3.12" | ||
|
|
There was a problem hiding this comment.
What made removing the os matrix necessary?
There was a problem hiding this comment.
mostly to reduce the amount of CI resources being burnt while testing
There was a problem hiding this comment.
mm, yeah i guess that's fair, but I think we need a decent spread.
We can loose some versions of python - now needs >3.10. We probably need windows tested as well tho. macos-12 is being discontinued soon, so that can go.
Not too worried about runner cost, but we should cover as much target user arch as we can. I can always set up some specific runners if the wait for runner availability is too long after that
| run: | | ||
| PATH=${GITHUB_WORKSPACE}/.verilator/bin:$PATH make verif-run-pyuvm | ||
|
|
||
| submit: |
There was a problem hiding this comment.
Whats the reasoning to remove the submit stage?
There was a problem hiding this comment.
because we don't actually have anything to submit yet
No description provided.