-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up netscanner
#42
Conversation
Amazing work - Thanks a lot. I was planing that after some time spend with rust as part of some refactoring huge part of
This is caused by concurrency problem that need to be refactored in
I think this will not speed up things that much, but it will not use that much memory - but I may need to be corrected on this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge work has been done from Your side @zanderlewis. Thank You very much.
Just for next time - I would recommend to create a new branch in your fork for any other next PR's that You would like to make. When someone would like to try fix some conflict, it would be much better to see unique names on branches to better understand from where, what has been added and etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested everything and beside that after scanning some subnet the arrow is not showed in the table it's looking really good. I'll solve that in another commit so don't worry about that.
Thank you very much for your help. I really appreciate that.
This PR speeds up
netscanner
by removing tons of.clone()
functions from various scripts..clone()
functions are replaced with references.Note
My last PR was my first time contributing code to another project, so I wanted to see if I can do anything else for the project!