add scope tags and aria-labels to instance table #2866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rigelk
requested changes
Jun 11, 2020
client/src/app/shared/instance/instance-features-table.component.scss
Outdated
Show resolved
Hide resolved
Pandoraaa
force-pushed
the
instance-table
branch
from
eaef591
to
77bbf38
Compare
rigelk
approved these changes
Jun 11, 2020
rigelk
changed the title
|
Thanks again @Pandoraaa 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will improve a11y with a table caption, table structure with scope to help screen readers and aria-label for its yes/no icons.