Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add scope tags and aria-labels to instance table #2866

Merged
merged 1 commit into from
Jun 11, 2020
Merged

add scope tags and aria-labels to instance table #2866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion client/src/app/+about/about-instance/about-instance.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@
</div>

<div class="col-md-12 col-xl-6">
<label i18n>Features found on this instance</label>
<my-instance-features-table></my-instance-features-table>
</div>

Expand Down
4 changes: 2 additions & 2 deletions client/src/app/shared/instance/feature-boolean.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<span *ngIf="value === true" class="glyphicon glyphicon-ok"></span>
<span *ngIf="value === false" class="glyphicon glyphicon-remove"></span>
<span *ngIf="value === true" class="glyphicon glyphicon-ok" i18n-aria-label aria-label="yes"></span>
<span *ngIf="value === false" class="glyphicon glyphicon-remove" i18n-aria-label aria-label="no"></span>

31 changes: 16 additions & 15 deletions client/src/app/shared/instance/instance-features-table.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,49 +1,50 @@
<div class="feature-table">

<table class="table" *ngIf="serverConfig">
<caption i18n>Features found on this instance</caption>
<tr>
<td i18n class="label">PeerTube version</td>
<th i18n class="label" scope="row">PeerTube version</th>

<td class="value">{{ getServerVersionAndCommit() }}</td>
</tr>

<tr>
<td i18n class="label">
<th i18n class="label" scope="row">
<div>Default NSFW/sensitive videos policy</div>
<div class="more-info">can be redefined by the users</div>
</td>
</th>

<td class="value">{{ buildNSFWLabel() }}</td>
</tr>

<tr>
<td i18n class="label">User registration allowed</td>
<th i18n class="label" scope="row">User registration allowed</th>
<td>
<my-feature-boolean [value]="serverConfig.signup.allowed"></my-feature-boolean>
</td>
</tr>

<tr>
<td i18n class="label" colspan="2">Video uploads</td>
<th i18n class="label" colspan="2">Video uploads</th>
</tr>

<tr>
<td i18n class="sub-label">Transcoding in multiple resolutions</td>
<th i18n class="sub-label" scope="row">Transcoding in multiple resolutions</th>
<td>
<my-feature-boolean [value]="serverConfig.transcoding.enabledResolutions.length !== 0"></my-feature-boolean>
</td>
</tr>

<tr>
<td i18n class="sub-label">Video uploads</td>
<th i18n class="sub-label" scope="row">Video uploads</th>
<td>
<span i18n *ngIf="serverConfig.autoBlacklist.videos.ofUsers.enabled">Requires manual validation by moderators</span>
<span i18n *ngIf="!serverConfig.autoBlacklist.videos.ofUsers.enabled">Automatically published</span>
</td>
</tr>

<tr>
<td i18n class="sub-label">Video quota</td>
<th i18n class="sub-label" scope="row">Video quota</th>

<td class="value">
<ng-container *ngIf="initialUserVideoQuota !== -1">
Expand All @@ -63,41 +64,41 @@
</tr>

<tr>
<td i18n class="label" colspan="2">Import</td>
<th i18n class="label" colspan="2">Import</th>
</tr>

<tr>
<td i18n class="sub-label">HTTP import (YouTube, Vimeo, direct URL...)</td>
<th i18n class="sub-label" scope="row">HTTP import (YouTube, Vimeo, direct URL...)</th>
<td>
<my-feature-boolean [value]="serverConfig.import.videos.http.enabled"></my-feature-boolean>
</td>
</tr>

<tr>
<td i18n class="sub-label">Torrent import</td>
<th i18n class="sub-label" scope="row">Torrent import</th>
<td>
<my-feature-boolean [value]="serverConfig.import.videos.torrent.enabled"></my-feature-boolean>
</td>
</tr>


<tr>
<td i18n class="label" colspan="2">Player</td>
<th i18n class="label" colspan="2">Player</th>
</tr>

<tr>
<td i18n class="sub-label">P2P enabled</td>
<th i18n class="sub-label" scope="row">P2P enabled</th>
<td>
<my-feature-boolean [value]="serverConfig.tracker.enabled"></my-feature-boolean>
</td>
</tr>

<tr>
<td i18n class="label" colspan="2">Search</td>
<th i18n class="label" colspan="2">Search</th>
</tr>

<tr>
<td i18n class="sub-label">Users can resolve distant content</td>
<th i18n class="sub-label" scope="row">Users can resolve distant content</th>
<td>
<my-feature-boolean [value]="serverConfig.search.remoteUri.users"></my-feature-boolean>
</td>
Expand Down
8 changes: 8 additions & 0 deletions client/src/app/shared/instance/instance-features-table.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ table {
}

&.sub-label {
font-weight: $font-regular;
padding-left: 30px;
}

Expand All @@ -27,6 +28,13 @@ table {
td {
vertical-align: middle;
}

caption {
caption-side: top;
font-size: 15px;
font-weight: $font-semibold;
color: pvar(--mainForegroundColor);
}
}