Add alert and hide upload view when no upload is possible

[kimsible]

When user video quota or daily upload limit are set to None - no upload possible, an alert should inform that upload is disabled for the account and the form view not displayed once clicked on the Upload button and accessing to /videos/upload.

This PR proposes a way to alert the user and hide the upload form in this case :

[rigelk]

Aside from a few errors that would need correction*, I'm pretty sure that message will never show, because the quota will never be reached exactly to the bit.

The idea is good though! Maybe a warning when below a certain percentage of the quota would be nice instead.

---

*you are using videoQuota and videoQuotaDaily, which don't reflect the used quota. For this you should use videoQuotaUsed and videoQuotaUsedDaily. I would also make the message clearer as to why the upload is not available.

[kimsible]

Aside from a few errors that would need correction*, I'm pretty sure that message will never show, because the quota will never be reached exactly to the bit.

The idea is good though! Maybe a warning when below a certain percentage of the quota would be nice instead.

*you are using videoQuota and videoQuotaDaily, which don't reflect the used quota. For this you should use videoQuotaUsed and videoQuotaUsedDaily. I would also make the message clearer as to why the upload is not available.

Yes I thought about the quota, and it would be nice to display it. But this PR is not really about used quota, it's about the option None - no upload possible selected by the admin for a user as bellow :

It's a specific case, when the user has no quota at all for a reason like having a user only to comment and no uploads.

I suggest to make the used quota warning in another PR with the display quota as /my-account/my-settings does.

[test2a]

Can you add a link to ping the instance mod in case you want more help/appeal the quota?
The screenshot above shows just a message. So presumably if I am disabled from uploading a video, I would have to go back and message admins about it.
Having a direct button to send a message would help the user imo

[kimsible]

Can you add a link to ping the instance mod in case you want more help/appeal the quota?
The screenshot above shows just a message. So presumably if I am disabled from uploading a video, I would have to go back and message admins about it.
Having a direct button to send a message would help the user imo

Thanks for your comment, you mean a link to the about page where contact form is when enabled ? it you the contact form is disabled what would you suggest to display ?

EDIT: Or maybe, each user would have the hability to contact the admin ? @rigelk ?

[rigelk]

@kimsible users should be able to contact the admin, yes.

[test2a]

@kimsible thanks. Yes. What I am saying is,
The screenshot says "Sorry, the upload feature is disabled for your account.".

What I am suggesting is "Sorry, the upload feature is disabled for your account. Click here to contact the admin for help."

This "here" could open the "contact administrator" form that shows up on the stat page

https://peertube2.cpy.re/about/instance

This would probably be a small papercut improvement but I do forsee the need for it. I could be wrong, maybe the team here can deliberate on this ?

[kimsible]

@kimsible thanks. Yes. What I am saying is,
The screenshot says "Sorry, the upload feature is disabled for your account.".

What I am suggesting is "Sorry, the upload feature is disabled for your account. Click here to contact the admin for help."

This "here" could open the "contact administrator" form that shows up on the stat page

https://peertube2.cpy.re/about/instance

This would probably be a small papercut improvement but I do forsee the need for it. I could be wrong, maybe the team here can deliberate on this ?

I suggest we redirect the button to the about page, because we miss the case some instance do not have the admin form enabled.

What do you think @test2a ?

[test2a]

@kimsible much improvement. Thanks. Thats the gist of what i was thinking. Now, a user who is seeing unable to upload any videos gets sent to a page explaining rules.
Earlier a user would be stuck, not knowing what to do.

Thanks for the efforts you guys put into the software. You are awesome. ?-)

[kimsible]

@Chocobozzz we have an issue here, it seems videosCount is always undefined in this context

[Chocobozzz]

Because we don't compute videosCount in the /me endpoint. I'll update this PR