Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display user quota progress bars above upload form #2981

Merged

Conversation

kimsible
Copy link
Contributor

@kimsible kimsible commented Jul 19, 2020

This PR follows extra infos upload form of this #2966.
This one display the user quota progress bars above the upload form.
The progress bar height has been doubled for more visibility and touch devices allowing to see the title on touch

video-quota2
video-quota1

@rigelk rigelk added the UI non-trivial UI changes, that might need discussion label Jul 20, 2020
@rigelk
Copy link
Collaborator

rigelk commented Jul 21, 2020

@kimsible doubling the bar height for visibility is a good idea! I'm not so sure about displaying the bars on the upload page though - at least not this way.

@kimsible
Copy link
Contributor Author

kimsible commented Jul 21, 2020

@rigelk what would you see to improve the UX ? an avatar of the user on the left ? an explicit title and help tooltips ?

For example Vimeo :
image
image

@Chocobozzz
Copy link
Owner

I think explicit titles would be better, because users won't really understand what are these progress bars when they come in the upload page for the first time

@Chocobozzz Chocobozzz added the Status: Waiting for answer Waiting issue author answer label Jul 23, 2020
@kimsible
Copy link
Contributor Author

With an explicit title and a tooltip with quota values for accessibility :

Capture d’écran du 2020-07-24 00-16-17
Screenshot_2020-07-24 Upload a video - mon instance

@kimsible kimsible force-pushed the feat/user-quota-to-upload-form branch from 4c25f4f to 995178f Compare July 23, 2020 22:23
@kimsible kimsible force-pushed the feat/user-quota-to-upload-form branch from 90556fe to 5678229 Compare July 23, 2020 22:38
@Chocobozzz
Copy link
Owner

Thanks, let's try this

@Chocobozzz Chocobozzz merged commit 2e7f262 into Chocobozzz:develop Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Waiting for answer Waiting issue author answer UI non-trivial UI changes, that might need discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants