Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Improve navigation user-dropdown, left-menu, my-account #2973

Closed

Conversation

kimsible
Copy link
Contributor

@kimsible kimsible commented Jul 15, 2020

@Chocobozzz
Copy link
Owner

Not reviewed the content, but from the UI perspective it's interesting. Just some comments:

  • A lot of people don't understand the channels concept, and don't really use it. So, should we put this in the menu?
  • I would rename More settings from the menu to just More, since it's not just about settings
  • I would keep the More settings below Help share videos in the account dropdown

@kimsible
Copy link
Contributor Author

kimsible commented Jul 26, 2020

Not reviewed the content, but from the UI perspective it's interesting. Just some comments:

  • A lot of people don't understand the channels concept, and don't really use it. So, should we put this in the menu?
  • I would rename More settings from the menu to just More, since it's not just about settings
  • I would keep the More settings below Help share videos in the account dropdown

Thanks ! it was a poc/test, this PR really needs to be rebased...

Yes the channels concept is not understandable for lots of people but maybe because it's not as visible as on the signup form, maybe it should be show up ?

Ok for the names corrections.

Do you think entries already in the left menu should be kept in the sub menu ?

I think the real problem of design here is that left menu, user dropdown and my-account sub-menu have each one their own logic / naming, the logic / naming should be harmonized in everywhere. So I hope this way could fit users needs..

Note, that my-account sub-menu can't be too large cause of limitations we fixed with dropdowns menus and responsive.

@Chocobozzz
Copy link
Owner

Do you think entries already in the left menu should be kept in the sub menu ?

I'm not sure to understand. Are you talking about I would keep the More settings below Help share videos in the account dropdown?

@test2a
Copy link
Contributor

test2a commented Aug 20, 2020

@kimsible on mobiles clicking on the profile sidebar on v 2.3.0 website throws the page to desktop mode, it does not accept the mobile resolution

@kimsible
Copy link
Contributor Author

@Chocobozzz I think this PR can be closed since you implemented the new user menu here #3296

@kimsible kimsible closed this Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants