Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update left menu and account menu #3296

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Update left menu and account menu #3296

merged 1 commit into from
Nov 13, 2020

Conversation

Chocobozzz
Copy link
Owner

@Chocobozzz Chocobozzz commented Nov 12, 2020

Updated the left menu:

  • Add My settings, My library, Administration (if admin) below the username
  • Renamed section titles to In my account, and On instance name for better block scopes identification
  • Removed Account settings and Channel settings from the user dropdown
  • Add *My notifications in the user dropdown

Splitted the account menu in two:

  • My library containing channels, videos, imports, ownership changes, playlists, subscriptions and history
  • My settings containing account settings, notifications and moderation tools

Others:

  • Moved My imports and Ownership changes links in the videos page, since it's related to the account videos so we have less entries in the main menu

Discussion:

  • Not sure if we use the orange color for active account links on the left menu:

screen_2020-11-12-16:16:48
screen_2020-11-12-16:16:13

  • Better name for My settings of the left menu?

Other screens:
screen_2020-11-12-16:19:47
screen_2020-11-12-16:16:59

@Chocobozzz Chocobozzz force-pushed the feature/account-menu branch 2 times, most recently from 047e9a4 to 8d64651 Compare November 12, 2020 15:39
@kimsible
Copy link
Contributor

kimsible commented Nov 12, 2020

Hi @Chocobozzz, congrat and thanks for all this work !

I love the way the menu entries are displayed now.

Splitting, my-library pages into a my-library page looks clearer, same for « Administration ».

Better name for My settings of the left menu?

Maybe simply « My account / Mon compte » ? I saw that Mobilizon uses that word, maybe we can try ?
I'm not sure if it's consistent with the notifications list and moderation options.

Not sure if we use the orange color for active account links on the left menu:

The --mainColorLighter with color: white on the svg looks bettter (but really not sure) :
image

Hover could be same as the other menu left items:
image

Also, I think you can now remove all the My ... on H1 titles, buttons and dropdown menus : My channels, My videos, My imports (h1 and button), My playlists, My ownership changes, My subscriptions, My history, My settings (sub menu), My notifications (sub menu), My abuse reports (in dropdown moderation menu).
=> Only My notifications in the user dropdown menu, My settings / account (or something else), My library would stay like that.

Video view is not mobile friendly :

Title buttons :
image

Control buttons :
image

@Chocobozzz
Copy link
Owner Author

Maybe simply « My account / Mon compte » ? I saw that Mobilizon uses that word, maybe we can try ?

Let's try that

The --mainColorLighter with color: white on the svg looks bettter (but really not sure) :

👍

Also, I think you can now remove all the My ... on H1 titles, buttons and dropdown menus

👍

Video view is not mobile friendly :

Fixed

@Chocobozzz
Copy link
Owner Author

Account item compromise, with an orange border on the left:

screen_2020-11-13-11:54:14

Add my-settings and my-library in left menu
Move administration below my-library
Split account menu: my-setting and my library
@Chocobozzz
Copy link
Owner Author

Merging but feel free to comment. We can still fix/change things

@Chocobozzz Chocobozzz merged commit 17119e4 into develop Nov 13, 2020
@kimsible
Copy link
Contributor

I like the orange border left =) great work, thanks!

@kimsible
Copy link
Contributor

Would the label « IN MY LIBRARY » fit better instead of « IN MY ACCOUNT » since My account concerns settings, notifications and moderation ?

image

@Chocobozzz
Copy link
Owner Author

@kimsible 👍 f0048d5

@Chocobozzz Chocobozzz deleted the feature/account-menu branch November 18, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants