changed video rating popover text with link to login page #3168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i was unable to add a link to login page due to probably html sanitization in the popover text. it should still satisfy the issue #3167
this display:none makes the text "friendly reminder" hidden on mobile devices. removing this should solve that
rigelk
changed the title
fflorent
pushed a commit
to fflorent/PeerTube
that referenced
this pull request
Dec 31, 2020
…#3168) Co-authored-by: Rigel Kent <sendmemail@rigelk.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this aims to solve #3167 and a separate issue where i found the warning about p2p sharing which is initially shown to all users does not show up correctly on mobile devices as is currently hidden. this pr aims to fix those things
@rigelk i was unable to add a link
also, i have used the word "video" instead of "content" as was earlier because the word video is already used in the UI at multiple places like in share > embed> "display video title". if this isnt acceptable, i can change it back, just let me know.