my bloody valentine preset #361
Conversation
|
also if you dont mind, can i merge request IRs? |
There was a problem hiding this comment.
Thanks for sharing... I think I prefer the first of the two presets, but I'll leave that decision up to you. I tried playing the chords/lead for "When You Sleep" through both presets... both sounded like the mbv "vibe" to me generally, although not exactly like the recordings, but that probably has more to do with my playing rather than the presets.
In order for the preset to be shipped with the plugin, there's a couple of changes that are required. First are some edits to the preset file itself, which are described in a comment. The other change is that we'll need to add the new preset to the list of presets in the code here (note that the list is in alphabetical order).
Please feel free to contribute more presets if you would like to!
| <Preset name="my bloody valentine" plugin="BYOD" vendor="User" category="" | ||
| version="1.3.0" preset_file="/home/henry/Sync/ThirdPartyStuff/.clap plugins/BYOD/userpresets/User/my bloody valentine.chowpreset"> |
There was a problem hiding this comment.
A couple things here...
- Who do you want to be listed as the preset "vendor"? It's totally cool to use your on name (or screen name).
- To follow the naming conventions used in the other preset, we would probably want the category to be "Players".
- For presets that are shipped with the plugin, I usually delete the
preset_filefield, since that will be meaningless on other users' computers.
Here's an example preset file if you want to have a look: https://github.com/Chowdhury-DSP/BYOD/blob/main/res/presets/Superdrag.chowpreset#L3
There was a problem hiding this comment.
Who do you want to be listed as the preset "vendor"? It's totally cool to use your on name (or screen name).
oh just list it as yourself for now, for the sake of convenience. put it under Players
For presets that are shipped with the plugin, I usually delete the preset_file field, since that will be meaningless on other users' computers.
yeah do that lol
|
is there no way to nest categories? id like to have more than one under CHOW/Player/mybloodyvalentine |
|
https://github.com/Chowdhury-DSP/BYOD/actions/runs/9341970549 what does this mean |
At the moment, there's no way to nest categories... I suppose we could add that in the future. That said, I'm not sure it makes sense to have two separate mbv presets, especially since the two are so similar.
I wouldn't worry about CI runs happening on your fork, I'll have the CI pipeline run on this PR in a minute. |
i could make more that sound different, it's the idea rather than the current presets
whats a CI run lol |
|
will this be merged? |
https://en.wikipedia.org/wiki/My_Bloody_Valentine_(band)