Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added parsing for optional job properties #11

Merged
merged 3 commits into from
Sep 20, 2022
Merged

feat: added parsing for optional job properties #11

merged 3 commits into from
Sep 20, 2022

Conversation

Jaryt
Copy link
Contributor

@Jaryt Jaryt commented Sep 9, 2022

No description provided.

@Jaryt Jaryt marked this pull request as draft September 9, 2022 22:14
@Jaryt
Copy link
Contributor Author

Jaryt commented Sep 9, 2022

Requires: CircleCI-Public/circleci-config-sdk-ts#139

@Jaryt Jaryt marked this pull request as ready for review September 20, 2022 20:27
brivu
brivu approved these changes Sep 20, 2022
View reviewed changes
Copy link

@brivu brivu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Jaryt Jaryt merged commit 6580474 into main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brivu brivu brivu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jaryt @brivu