Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add optional properties to parameterized jobs #139

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Conversation

Jaryt
Copy link
Contributor

@Jaryt Jaryt commented Sep 9, 2022

No description provided.

@ghost
Copy link

ghost commented Sep 9, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #139 (6c47835) into main (33e9329) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files          61       61           
  Lines         658      658           
  Branches       64       64           
=======================================
  Hits          640      640           
  Misses          7        7           
  Partials       11       11           
Impacted Files Coverage Δ
src/lib/Components/Job/exports/ParameterizedJob.ts 100.00% <100.00%> (ø)
src/lib/Components/Job/index.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Jaryt Jaryt changed the title feat: add optional properties to parameterized jobs feat!: add optional properties to parameterized jobs Sep 9, 2022
Copy link

@brivu brivu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@tapesec tapesec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

src/lib/Components/Job/index.ts Show resolved Hide resolved
@mathieutu
Copy link
Contributor

We also have to add it in JobContentsShape 🙂.

@Jaryt Jaryt merged commit f53d462 into main Sep 13, 2022
@Jaryt Jaryt deleted the feat/param-job-envs branch September 13, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants