Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Job parallelism property is not displayed #141

Closed
2 of 4 tasks
tapesec opened this issue Sep 12, 2022 · 4 comments
Closed
2 of 4 tasks

Bug: Job parallelism property is not displayed #141

tapesec opened this issue Sep 12, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@tapesec
Copy link
Contributor

tapesec commented Sep 12, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

The parallelism option is supposed to available for a job.
This parallelism property is available into the Job class constructor but it is not passed to the generateContents method so you can’t see it in the final generated .yml config.

Minimum reproduction code

<script src="https://gist.github.com/tapesec/a2ba9bce9b2ca88542bd4cc05edca154.js"></script>

Steps to reproduce

No response

Expected behavior

The parallelism property passed to the Job class constructor is not returned from the generateContents method.
I added it.

CircleCI Config SDK version

v0.9.0-alpha.21

Node.js version

16.13.0

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Other

No response

@tapesec tapesec added the bug Something isn't working label Sep 12, 2022
@tapesec tapesec changed the title Bug: Bug: Job parallelism property is not displayed Sep 12, 2022
@tapesec
Copy link
Contributor Author

tapesec commented Sep 12, 2022

I’ve created a PR to fix it but I can’t push it because I haven’t access right. Could you grant me up please ?

@KyleTryon
Copy link
Contributor

Hey @tapesec You should be able to open a PR from a fork without any special access. Could you link us to your branch on GitHub?

@tapesec
Copy link
Contributor Author

tapesec commented Sep 13, 2022

Oh sorry my bad I cloned the repo I didn’t fork it :(
Now it’s done here is the link to my PR #142

tapesec added a commit to tapesec/circleci-config-sdk-ts that referenced this issue Sep 13, 2022
tapesec added a commit to tapesec/circleci-config-sdk-ts that referenced this issue Sep 13, 2022
@KyleTryon
Copy link
Contributor

Closed in #139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants