-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Yarn Berry global cache #201
Merged
EricRibeiro
merged 2 commits into
CircleCI-Public:master
from
blimmer:support-yarn-berry-global-cache
Jan 4, 2024
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -176,7 +176,8 @@ steps: | |
- save_cache: | ||
key: node-deps-{{ arch }}-<<parameters.cache-version>>-<<#parameters.include-branch-in-cache-key>>{{ .Branch }}-<</parameters.include-branch-in-cache-key>><<^parameters.cache-only-lockfile>>{{ checksum "/tmp/node-project-package.json" }}-<</parameters.cache-only-lockfile>>{{ checksum "/tmp/node-project-lockfile" }} | ||
paths: | ||
- <<parameters.app-dir>>/.yarn/cache | ||
- ~/.yarn/berry/cache # global cache, the default in Yarn Berry v4+ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FYI, the documentation on this is incorrect right now: https://yarnpkg.com/configuration/yarnrc#globalFolder. See yarnpkg/berry#6003 for a PR to update the docs to be correct. |
||
- <<parameters.app-dir>>/.yarn/cache # project cache, the default in Yarn Berry > 2 and < 4 | ||
- when: | ||
condition: << parameters.with-cache >> | ||
steps: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When updating versions of
yarn
, it writes thepackageManager
key topackage.json
. So, when updating between Yarn 3 and 4, it should trigger a cache invalidation based on this existing key.There is a corner-case where someone updated to Yarn 4 with an older version of this orb where they wouldn't get the global cache. However, it didn't feel important enough to update this key to invalidate all Yarn Berry caches with this change.