AU-2220: Remove top margin from hds-notifications when they are the first child

[teroelonen]

AU-2220

What was done

• Removed the top margin on notification since it only creates extra margin between elements when we are always adding margin on the bottom of elements. I realize this might cause issues somewhere around the site so that when the notification pops up it is attached to the element above, but I think we should solve those issues with spacing on the bottom of the element that the notification gets attached to because all other elements on the site work this way.

How to install

• Make sure your instance is up and running on latest dev branch.
  • git pull origin dev
  • make fresh
• Update the HDBT theme
  • composer require drupal/hdbt:dev-AU-2220
• Run make drush-cr

How to test

• Do something on the site that will create a notification such as editing and then saving a node. The first notification shouldn't have margin on top anymore.
• Check that code follows our standards

Continuous documentation

• This feature has been documented/the documentation has been updated
• This change doesn't require updates to the documentation

Other PRs

• AU-2220: Add spacing for the role selector block hel-fi-drupal-grants#1460
• AU-2220: Remove top margin from hds-notifications when they are the first child #1017

[github-actions]

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1017/html_report/

[khalima]

It does indeed remove the top margin of a first system message.