Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AU-2220: Add spacing for the role selector block #1460

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Jun 27, 2024

AU-2220

What was done

  • Add spacing for role selector block so that announcements are not attached to it.
  • Fix logic on the field template so that it doesn't show labels where it shouldn't like for example on announcements on view application page.

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout AU-2220
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-AU-2220
  • Run make drush-cr

How to test

  • Add an announcement on the page that is visible on all pages.
  • Make sure the announcement is not attached to the role selector block when logged in.
  • Go to view a sent application and if you don't have one then sent one (https://hel-fi-drupal-grant-applications.docker.so/fi/hakemus/LOCALSUVITEST-054-0000161/katso). The announcement on that base shouldn't have label anymore on the body field and the layout should look correct.
  • Check that code follows our standards

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Automatic- / Regression tests

  • This PR makes no changes that effects any tests. (This will be caught in automatic testing later on, but please, please run regression tests always on PR before asking for a review)
  • This PR passes regression tests. (make test-pw)

Other PRs

…where it shouldn't like for example on announcements on view application page
@teroelonen teroelonen changed the title AU-2220: AU-2220: Add spacing for the role selector block Jun 27, 2024
Copy link

@suvikankare suvikankare self-requested a review June 27, 2024 13:19
@jiisuominen jiisuominen merged commit 0b7d2ef into develop Jul 1, 2024
3 checks passed
@jiisuominen jiisuominen deleted the AU-2220 branch July 1, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants