Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burninate server-side rendering #413

Merged
merged 1 commit into from
Oct 4, 2017
Merged

Burninate server-side rendering #413

merged 1 commit into from
Oct 4, 2017

Conversation

akx
Copy link
Contributor

@akx akx commented Sep 25, 2017

This PR removes the server-side rendering code.

  • Every non-API URL will just always return the HTML skeleton without an attempt to render the app.
  • Running with the serverRendering config option is now an error.

Refs: #405 #133 #58 #317 etc.

@codecov-io
Copy link

codecov-io commented Sep 25, 2017

Codecov Report

Merging #413 into master will decrease coverage by 10.1%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #413       +/-   ##
===========================================
- Coverage   26.87%   16.77%   -10.11%     
===========================================
  Files         117      116        -1     
  Lines        2590     2540       -50     
  Branches      436      425       -11     
===========================================
- Hits          696      426      -270     
- Misses       1596     1749      +153     
- Partials      298      365       +67
Impacted Files Coverage Δ
server/getSettings.js 0% <0%> (ø) ⬆️
server/render-middleware.js 0% <0%> (ø) ⬆️
src/components/Footer.js 0% <0%> (-100%) ⬇️
src/getRoot.js 0% <0%> (-100%) ⬇️
server/Html.js 0% <0%> (-100%) ⬇️
src/utils/FormatRelativeTime.js 14.28% <0%> (-85.72%) ⬇️
src/views/Hearing/Sidebar.js 2.56% <0%> (-71.8%) ⬇️
src/App.js 14.28% <0%> (-71.43%) ⬇️
src/views/Hearing/Header.js 16.66% <0%> (-66.67%) ⬇️
src/components/SectionList.js 16.66% <0%> (-66.67%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8dfb05...fc1bac7. Read the comment docs.

@ghost ghost assigned akx Sep 25, 2017
@ghost ghost added the in progress label Sep 25, 2017
@akx akx requested review from vikoivun and Rikuoja September 25, 2017 15:08
@Rikuoja Rikuoja merged commit d799de2 into master Oct 4, 2017
@ghost ghost removed the in progress label Oct 4, 2017
@akx akx deleted the burninate-ssr branch November 13, 2017 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants