Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burninate server-side rendering #413

Merged
merged 1 commit into from
Oct 4, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 0 additions & 37 deletions __tests__/server-rendered-hearing.js

This file was deleted.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "0.0.0",
"main": "index.js",
"scripts": {
"start": "node server --server-rendering",
"start": "node server",
"build": "true",
"dev": "node server --dev",
"lint": "eslint src server test",
Expand Down
4 changes: 3 additions & 1 deletion server/getSettings.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ const defaults = {
sessionSecret: null,
uiConfig: null,
dev: false,
serverRendering: false,
cold: false,
bundleSrc: null, // Usually generated by the boot-time compilation process
};
Expand Down Expand Up @@ -47,5 +46,8 @@ export default function getOptions() {
if (missingKeys.length) {
throw new Error("These configuration values are required but are currently missing: " + missingKeys.join(", "));
}
if (settings.serverRendering) {
throw new Error("Server rendering is not currently supported.");
}
return settings;
}
18 changes: 16 additions & 2 deletions server/render-middleware.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,18 @@
import render from "./render";
import React from 'react';
import {renderToStaticMarkup} from 'react-dom/server';
import Html from './Html';


function renderHTMLSkeleton(req, res, settings) {
const html = renderToStaticMarkup(
<Html
bundleSrc={settings.bundleSrc || '/app.js'}
apiBaseUrl={settings.apiBaseUrl}
uiConfig={settings.uiConfig}
/>
);
res.status(200).send(html);
}

export default function renderMiddleware(settings) {
return (req, res, next) => {
Expand All @@ -21,6 +35,6 @@ export default function renderMiddleware(settings) {
if (req.url.indexOf(".") > -1) {
return next();
}
return render(req, res, settings);
return renderHTMLSkeleton(req, res, settings);
};
}
131 changes: 0 additions & 131 deletions server/render.js

This file was deleted.