Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

Update to throw exceptions instead of logging errors [np-core] #888

Closed
ixje opened this issue Feb 13, 2019 · 0 comments
Closed

Update to throw exceptions instead of logging errors [np-core] #888

ixje opened this issue Feb 13, 2019 · 0 comments

Comments

@ixje
Copy link
Member

ixje commented Feb 13, 2019

This is a TODO for a project (see side bar)

Remove the logzero package dependency from neo-python-core and update the logging calls with raising the appropriate exceptions.

  • Do not use the generic Exception class but use the more specific exception classes like ValueError, TypeError etc (standard lib exceptions).
  • Create custom exceptions if needed to give sufficient control to the end-user.

First update neo-python-core, then update neo-python to deal with the new exceptions.

@ixje ixje changed the title Update to throw exceptions instead of logging errors Update to throw exceptions instead of logging errors [np-core] Feb 13, 2019
jseagrave21 pushed a commit to jseagrave21/neo-python that referenced this issue Mar 12, 2019
@jseagrave21 jseagrave21 mentioned this issue Mar 12, 2019
5 tasks
jseagrave21 pushed a commit to jseagrave21/neo-python that referenced this issue Mar 18, 2019
ixje pushed a commit that referenced this issue Mar 21, 2019
@ixje ixje closed this as completed Aug 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant