Support #888

[jseagrave21]

What current issue(s) does this address, or what feature is it adding?
Supports CityOfZion/neo-python-core#169 which addresses #888.

How did you solve this problem?
See CityOfZion/neo-python-core#169

How did you make sure your solution works?
make test

Are there any special changes in the code that we should be aware of?
No

Please check the following, if applicable:

• Did you add any tests?
• Did you run make lint?
• Did you run make test?
• Are you making a PR to a feature branch or development rather than master?
• Did you add an entry to CHANGELOG.rst? (if not, please do)

[ixje]

The made changes all look good and tests pass if I pull your neo-python-core version. A couple of improvements that we can do (needs CityOfZion/neo-python-core#169 (review))

1. this can now throw a ValueError
   

   neo-python/neo/SmartContract/ContractParameterContext.py

   Lines 168 to 171 in fe90f62

   	while reader.ReadUInt8() == 33:
   	ecpoint = ecdsa.ec.decode_from_hex(binascii.hexlify(reader.ReadBytes(33)).decode())
   	points.append(ecpoint)
   	ms.close()

   
   Please update to

try:
  while reader.ReadUInt8() == 33:
     ecpoint = ecdsa.ec.decode_from_hex(binascii.hexlify(reader.ReadBytes(33)).decode())
     points.append(ecpoint)
except ValueError:
   return False
finally:
   ms.close()

2. neo-python/neo/Prompt/Utils.py

   Line 329 in fe90f62

   return ECDSA.decode_secp256r1(result).G, False

   
   replace with

try:
   return ECDSA.decode_secp256r1(result).G, False
except ValueError:
   return None, True

3. neo-python/neo/Prompt/Commands/Invoke.py

   Line 652 in fe90f62

   pubkey = ECDSA.decode_secp256r1(items[0]).G

   
   update to capture ValueError and inform user that their public key is invalid

4. neo-python/neo/SmartContract/StateMachine.py

   Line 149 in fe90f62

   owner = ECDSA.decode_secp256r1(ownerData, unhex=False).G

   
   update to capture ValueError and return False

5. neo-python/neo/SmartContract/StateReader.py

   Line 349 in fe90f62

   point = ECDSA.decode_secp256r1(hashOrPubkey, unhex=False).G

   
   update to capture ValueError and return False

Note: I skipped the calls in the Blockchain, Contract, ContractParameter classes on purpose as they already have undefined behaviour. I don't have the time to investigate them now and apparently they've worked fine up to now. The above requests have a clear way of dealing with them

[ixje]

2 small requests;

1. can you point travis to the development branch of neo-python-core. I just created that and already holds your core exception changes. So this change will allow us to continue working without having to already do a neo-python-core and neo-python release.

Before

neo-python/.travis.yml

Line 24 in fe90f62

- pip install -e git+https://github.com/CityOfZion/neo-python-core@master#egg=neocore

After

 - pip install -e git+https://github.com/CityOfZion/neo-python-core@development#egg=neocore 

2. please resolve the changelog

[coveralls]

Coverage decreased (-0.04%) to 86.532% when pulling d1261a1 on jseagrave21:support-#888 into 2fd24ce on CityOfZion:development.

[ixje]

💪

[ixje]

200 points jseagrave

[lllwvlvwlll]

https://neoscan.io/transaction/d5ae4a22ffe49912a2a3dc698d39ac63a8fcf2cef63ae136850d039c312591d8