remove disable_xp_orbs

[jjj5311]

May add into its own method but I dont think performance wise it will even help

[CivcraftBot]

Can one of the admins verify this patch? Type 'ok to test' to test.

[jjj5311]

#22

[ttk2]

we are removing this because its not duplicate with Factorymod right?

On Mon, May 18, 2015 at 11:25 AM jjj5311 notifications@github.com wrote:

#22 #22

—
Reply to this email directly or view it on GitHub
#44 (comment).

[jjj5311]

Removing cause it's essentially useless

On Monday, May 18, 2015, ttk2 notifications@github.com wrote:

we are removing this because its not duplicate with Factorymod right?

On Mon, May 18, 2015 at 11:25 AM jjj5311 <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

#22 #22

—
Reply to this email directly or view it on GitHub
#44 (comment).

—
Reply to this email directly or view it on GitHub
#44 (comment).

[rourke750]

@jjj5311 useless how? Is this code somewhere else?

[jjj5311]

Not yet, it only disabled xp orbs dropped from killing mobs... I will add a
method in the future that will actually disable all xp orbs from mobs,
mining, and whatever else you can get orbs from in vanilla

On Tue, May 19, 2015 at 4:16 PM, rourke750 notifications@github.com wrote:

@jjj5311 https://github.com/jjj5311 useless how? Is this code somewhere
else?

—
Reply to this email directly or view it on GitHub
#44 (comment).

[rourke750]

Well, id rather not remove this and let people get xp without a fix :/

[jjj5311]

xp is still disabled... this only removes the orbs

On Tue, May 19, 2015 at 4:19 PM, rourke750 notifications@github.com wrote:

Well, id rather not remove this and let people get xp without a fix :/

—
Reply to this email directly or view it on GitHub
#44 (comment).

[jjj5311]

https://github.com/Civcraft/Humbug/blob/master/src/main/java/com/untamedears/humbug/Humbug.java#L1712

[jjj5311]

@rourke750 this should be merged

[rourke750]

Did you test to see if they would not spawn?

[jjj5311]

They xp orbs will spawn without this, however players are not awarded xp from orbs since https://github.com/Civcraft/Humbug/blob/master/src/main/java/com/untamedears/humbug/Humbug.java#L1712

[rourke750]

I don't think you are linking to the right line.

[jjj5311]

yeah forgot to check the link i just copied it

https://github.com/Civcraft/Humbug/blob/master/src/main/java/com/untamedears/humbug/Humbug.java#L1768

[rourke750]

That's only triggered when a player throws an xp bottle.
On Jul 2, 2015 11:16 AM, "jjj5311" notifications@github.com wrote:

yeah forgot to check the link i just copied it

https://github.com/Civcraft/Humbug/blob/master/src/main/java/com/untamedears/humbug/Humbug.java#L1768

—
Reply to this email directly or view it on GitHub
#44 (comment).

[jjj5311]

Look down to the next method

[jjj5311]

https://github.com/Civcraft/Humbug/blob/master/src/main/java/com/untamedears/humbug/Humbug.java#L1782