Recent configuration option "disable_xp_orbs" is misleading and needs adjustment.

[Pentom]

Recent configuration option "disable_xp_orbs" is misleading and needs adjustment.

Reference: http://www.reddit.com/r/Civcraft/comments/32bqoe/morning_changelog_20150412/cq9rgn3

Basically, the disable xp drops just happens to disable the xp orbs from dropping from some animals but at the same time allows mob item multiplication. At the least, the configuration options need to be split so that we dont have this one feature being the trigger for both of these features. Unless theres a reason, though, its best to remove the xp orb dropping 'config option and feature' completely since it competes with the disable xp humbug configuration option.

If we really want to stop xp orbs from showing up then I would just have that functionality based off of the disable_experience check. Discovered while reviewing code pull 21 from tealnerd.

[ttk2]

This is probably a good point. Humbug is a bit of a mess anyways.

On Sun, Apr 12, 2015, 9:00 AM Pentom notifications@github.com wrote:

Recent configuration option "disable_xp_orbs" is misleading and needs
adjustment.

Reference:
http://www.reddit.com/r/Civcraft/comments/32bqoe/morning_changelog_20150412/cq9rgn3

Basically, the disable xp drops just happens to disable the xp orbs from
dropping from some animals but at the same time allows mob item
multiplication. At the least, the configuration options need to be split so
that we dont have this one feature being the trigger for both of these
features. Unless theres a reason, though, its best to remove the xp orb
dropping 'config option and feature' completely since it competes with the
disable xp humbug configuration option.

If we really want to stop xp orbs from showing up then I would just have
that functionality based off of the disable_experience check. Discovered
while reviewing code pull 21 from tealnerd.

—
Reply to this email directly or view it on GitHub
#22.

[suirad]

Looks like there is a pull for this, but it hasn't been merged. Wontfix?

[jjj5311]

that pull should be merged

On Wed, Sep 30, 2015 at 12:17 PM, Darius Scott notifications@github.com
wrote:

Looks like there is a pull for this, but it hasn't been merged. Wontfix?

—
Reply to this email directly or view it on GitHub
#22 (comment).

[ttk2]

the reference one? It needs rebasing from what I can see.