Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kaluptic psychosis illusion NPCs dropped weapons do not disapper with them #58640

Closed
Maduscientistu opened this issue Jun 23, 2022 · 5 comments
Closed
Labels
<Bug> This needs to be fixed NPC / Factions NPCs, AI, Speech, Factions, Ownership (S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@Maduscientistu
Copy link

Describe the bug

Now that we can talk with the NPCs we can tell them to drop their weapons. A weapon dropped this way remains in the game after the NPC disappears and the hallucinations status effect passes. I had an NPC drop a sickle that persisted this way. I also got a beebot to drop honeycomb when they disappear. I found a honeycomb on the ground randomly where i think i hit a beebot but was not sure, later another beebot showed up and when i made it disappear there was another honeycomb on the ground. This is a easily ignored thing but here it is anyways thanks for the great game guys.

Steps to reproduce

  1. Have Kaluptic Psychosis
  2. Hallucinate
  3. Talk to an illusional NPC
  4. Tell them to drop their weapons
  5. Sleep until the hallucinations stops
  6. The weapon remains

Expected behavior

No weapons dropped. Maybe this can be fixed by only spawning illusion NPCs with nothing on their hands?

Screenshots

Sorry character already dead but here is the sickle when i got a new character to the base.
image

Versions and configuration

Experimental 20/06/2022

Additional context

No response

@Maduscientistu Maduscientistu added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Jun 23, 2022
@NetSysFire
Copy link
Member

@dseguin since you did #54307, could you take a look at this, too?

@Night-Pryanik
Copy link
Contributor

Can't confirm on 0.F-9789.

This guy with the exclamation mark is a hallucination
изображение

The game says that he drops his weapon
изображение

But actually he still wields it
изображение

Game explicitly states that if NPC is a hallucination, then actual dropping should fail silently.

void talk_function::drop_weapon( npc &p )
{
if( p.is_hallucination() ) {
return;
}

@NetSysFire NetSysFire added <Bug> This needs to be fixed NPC / Factions NPCs, AI, Speech, Factions, Ownership (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Jul 9, 2022
@Night-Pryanik
Copy link
Contributor

@NetSysFire why is this issue has "confirmed" tag? I tested the issue, and my tests demonstrated that hallucination NPC don't drop their weapons.

NPC saying he drops his weapon while actually he doesn't looks more like a feature of hallucination rather than a game bug IMO.

@NetSysFire
Copy link
Member

Unsure. Might have fat-fingered the label.

@Night-Pryanik
Copy link
Contributor

Closing as unconfirmed. If it's still reproducible somehow, ping me to reopen.

@Night-Pryanik Night-Pryanik closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed NPC / Factions NPCs, AI, Speech, Factions, Ownership (S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

No branches or pull requests

3 participants