Hallucinations: Misc fixes

[dseguin]

Summary

None

Purpose of change

Fixes #53674.
Fixes #53678.
Fixes #52808.
Fixes #53675.

Describe the solution

Add additional checks for hallucinations on various actions in monster::move, as well as conditional dialogue for hallucinated NPCs. This fixes certain actions to/from hallucinations:

• Hallucinated monsters can only target other hallucinations or the player
• Hallucinated monsters cannot shove vehicles
• Hallucinated monsters and NPCs cannot open doors
• Attempts to steal from hallucinations always fail
• Player can no longer trade with hallucinations via interaction menu
• Hallucinated NPCs cannot train the player (and vis-versa)

Describe alternatives you've considered

I guess some of these bugs could be written off as "the player imagined opening the door/finding that item/etc."

There's some additional weirdness about hallucinations that I haven't addressed here, like projectiles that do real damage (and grenades...)

Testing

---

Hallucinations can only target other hallucinations and the player

Spawning a zombie hulk (real) and a giant wasp (hallucinated):

Spawning a zombie hulk and a giant wasp (both hallucinated):

They attack each other, but nothing is printed to the log.

---

Hallucinations can't shove vehicles

Spawning a zombie hulk next to a beetle results in the hulk shoving the car:

Trying the same with a hallucinated zombie hulk results in the car not being shoved.

---

Hallucinations can't open doors

(Left: hallucinated feral human, right: real feral human)

---

Attempting to steal from a hallucination

---

Asking hallucination to train the player

---

Attempting to trade via interaction menu

---

Additional context

TODO:

• Restore teleporting hallucinations (so they can move through doors) Looks like it was never broken to begin with
• Modify friendly dialogue options to prevent taking/giving items from/to hallucinations
• Testing

[Fris0uman]

All checks to convince a hallucinated NPC to follow are rejected

Befriending hallucination was one of the main point to make hallucination NPcs in the first place #28157

[dseguin]

Befriending hallucination was one of the main point to make hallucination NPcs in the first place #28157

I see, no problem. I'll revert that particular change.

[Fris0uman]

Also I don't know what happened to that piece of code but in the initial implementation NPC hallucination were setup to teleport throgh doors without opening them.

Because if they can't open doors at all they'll stay stuck on the other side instead of following you.

[dseguin]

That's weird, I'll see if I can restore that behaviour.

[kevingranade]

"the player imagined opening the door/finding that item/etc."

There's a whole different can of worms concerning potential hallucinatory items or even hallucinatory changes to the map but the question there is where does it stop and I think unless someone is super super passionate about making a deeper hallucination system that stopping roughly where you have it is the right way to go

[dseguin]

Because if they can't open doors at all they'll stay stuck on the other side instead of following you.

It looks like that behaviour still works:

2022-01-11.22-02-35.mp4

Not sure if that's the way it's supposed to work, but the door remains closed.