Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iterator_traits<vehicle_part_iterator<T>> is missing reference #58647

Merged
merged 2 commits into from
Jun 24, 2022
Merged

iterator_traits<vehicle_part_iterator<T>> is missing reference #58647

merged 2 commits into from
Jun 24, 2022

Conversation

SaumyaBhushan
Copy link
Contributor

@SaumyaBhushan SaumyaBhushan commented Jun 23, 2022 •
edited
Loading

Summary

None

Purpose of change

Fix #58643

Describe the solution

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added the [C++] Changes (can be) made in C++. Previously named `Code` label Jun 23, 2022
Qrox
Qrox reviewed Jun 23, 2022
View reviewed changes
src/vpart_range.h Outdated Show resolved Hide resolved
@BrettDong
Copy link
Member

Please follow the pull request template to pick a category (can be None) to fill in the summary line. The summary line is mandatory so we can generate change log from pull requests on GitHub.

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 23, 2022
@PatrikLundell
Copy link
Contributor

I would guess that this PR is intended to address #58643? If that's the case, adding "Fix #58643" (without the quotes) under "Purpose of change" would link the PR to that issue and cause it to be closed automatically when this PR is closed due to being merged.

@SaumyaBhushan
Copy link
Contributor Author

SaumyaBhushan commented Jun 24, 2022 •
edited
Loading

I would guess that this PR is intended to address #58643? If that's the case, adding "Fix #58643" (without the quotes) under "Purpose of change" would link the PR to that issue and cause it to be closed automatically when this PR is closed due to being merged.

I have linked this PR with the issue. Thanks for the help.

@dseguin dseguin merged commit 17fe4d8 into CleverRaven:master Jun 24, 2022
@SaumyaBhushan SaumyaBhushan deleted the Issue#58643 branch June 24, 2022 05:38
Drew4484 pushed a commit to Drew4484/Cataclysm-DDA that referenced this pull request Jun 24, 2022
@SaumyaBhushan @Drew4484
iterator_traits<vehicle_part_iterator<T>> is missing reference (Cleve…
d00a1c7 
…rRaven#58647)

* iterator_traits<vehicle_part_iterator<T>> is missing reference

* added comments
tornikeo pushed a commit to tornikeo/Cataclysm-DDA that referenced this pull request Jun 26, 2022
@SaumyaBhushan @tornikeo
iterator_traits<vehicle_part_iterator<T>> is missing reference (Cleve…
1c5b24f 
…rRaven#58647)

* iterator_traits<vehicle_part_iterator<T>> is missing reference

* added comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qrox Qrox Qrox left review comments

@BrettDong BrettDong BrettDong approved these changes

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iterator_traits<vehicle_part_iterator<T>> is missing reference
5 participants
@SaumyaBhushan @BrettDong @PatrikLundell @Qrox @dseguin