Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump ubuntu image and minimum compiler versions #64011

Merged
merged 5 commits into from
Mar 12, 2023

Conversation

kevingranade
Copy link
Member

@kevingranade kevingranade commented Mar 6, 2023

Summary

None

Purpose of change

Github is in the process of EOLing ubuntu 18.04 actions/runner-images#6002

In particular, we are seeing brownouts from github actions using this image, which causes waves of basic build failures across all PRs.

We're also already eyeballing newer compiler features, i e. C++17 #63970

@github-actions github-actions bot added Code: Tooling Tooling that is not part of the main game but is part of the repo. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 6, 2023
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 7, 2023
@kevingranade kevingranade marked this pull request as ready for review March 7, 2023 06:46
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 7, 2023
@kevingranade
Copy link
Member Author

This is blocked from merging because of branch protection rules that say "Basic Build and Test (Clang 6, Ubuntu, Curses)" must pass, and this changes the name of the test.
To push this change I'll have to disable that rule for a while until all the PRs that have already passed that test have been merged, then we can turn it back on using the new name.

@jbytheway jbytheway mentioned this pull request Mar 11, 2023
@kevingranade kevingranade merged commit db82caa into master Mar 12, 2023
@kevingranade kevingranade deleted the kevingranade-bump-vers branch March 12, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant