Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Julia version for EKS #41

Closed
wants to merge 10 commits into from
Closed

Conversation

charleskawczynski
Copy link
Member

Copied from #40

@agarbuno
Copy link
Collaborator

Got it. I believe almost all of the EKS update is already in the EKS.jl file. As soon as we are comfortable with the final version we can delete the python template and the bkp.jl file.

@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #41 into master will decrease coverage by 1.80%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
- Coverage   59.17%   57.37%   -1.81%     
==========================================
  Files          12       12              
  Lines         485      502      +17     
==========================================
+ Hits          287      288       +1     
- Misses        198      214      +16     
Impacted Files Coverage Δ
src/EnsembleKalmanProcesses.jl 72.88% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35d3feb...982430e. Read the comment docs.

@charleskawczynski
Copy link
Member Author

@agarbuno I think this is ready if you're fine with the changes. Let me know, and I can rebase

@agarbuno
Copy link
Collaborator

Sure. I´ll take a look. Thanks a lot @charleskawczynski ! I'll get back to you tomorrow with news on this.

@charleskawczynski
Copy link
Member Author

@agarbuno, you'll need to resolve these conflicts as this has gotten out of sync after the last merge(s).

@bielim
Copy link
Contributor

bielim commented Aug 12, 2020

Closing this PR; it has been superseded by #70 and #76.

@bielim bielim closed this Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants