-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add Ensemble Kalman Sampler #70
Conversation
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
==========================================
+ Coverage 81.99% 82.72% +0.73%
==========================================
Files 7 7
Lines 422 440 +18
==========================================
+ Hits 346 364 +18
Misses 76 76
Continue to review full report at Codecov.
|
@agarbuno: This PR is based on your EKS implementation. However, the EKS update needs some revision: First, it errored due to dimensional mismatches, which led me to look at the implicit equation implemented in lines 250-256 in |
76: Change code infrastructure to accommodate both EKI and EKS r=bielim a=bielim This PR is an interim solution, to be superseded by PR #70 as soon as the EKS implementation has been finalized. It implements the new "EK infrastructure" with the abstract type `Process` that allows the user to choose between an EK `Sampler` and an EK `Inversion`, but since the correct ensemble update for the EK Sampler is not known yet (see discussion in the comment section of PR #70), an attempt to instantiate an EK `Sampler` is prohibited and will throw an error. The point of merging this PR before completion of the EK Sampler implementation is to not block the further development of the code base, which depends on the infrastructure introduced in this PR. Co-authored-by: Melanie Bieli <melanie.bieli@bluewin.ch>
This PR adds a Julia implementation of an Ensemble Kalman Sampler. It supersedes PR #41.