-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implicit stencil test time regression #1134
Labels
Comments
I've got a wip file where I was experimenting/digging around to find out what's wrong. |
Along with:
push!(ARGS, "--float_type", "Float32")
include(joinpath("test", "Operators", "finitedifference", "implicit_stencils_utils.jl"))
(s, parsed_args) = parse_commandline();
const FT = parsed_args["float_type"] == "Float64" ? Float64 : Float32
function do_work(all_ops)
for _ in 1:100
test_pointwise_stencils_apply(all_ops)
# test_pointwise_stencils_compose(all_ops)
end
end
center_space = get_space(FT);
all_ops = get_all_ops(center_space);
do_work(all_ops) # compile first, toggle to see compile time allocations
import Profile
import ClimaCore
Profile.clear_malloc_data()
Profile.clear()
prof = Profile.@profile do_work(all_ops)
import ProfileCanvas
ProfileCanvas.html_file(joinpath(pkgdir(ClimaCore), "implicit_stencil_flame.html")) Requires #1229. |
#1305 seems to have fixed this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
#767 appears to have caused the implicit stencil tests to go from ~20 mins to ~60 mins. This is probably caused by the DataLayouts changes
The text was updated successfully, but these errors were encountered: