Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break up implicit stencil tests for improving inference #1229

Merged
merged 2 commits into from
May 7, 2023
Merged

Break up implicit stencil tests for improving inference #1229

merged 2 commits into from
May 7, 2023

Conversation

charleskawczynski
Copy link
Member

CI times have increased and are a bit of a drag, mostly due to the implicit stencil tests, which take ~1hr.

This PR breaks up these tests into separate functions to help more easily utilize inference tools to understand why it's taking so long.

@charleskawczynski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request May 5, 2023
@bors
Try #1229:
a42cb99
@charleskawczynski charleskawczynski mentioned this pull request May 5, 2023
Closed
@bors
Copy link
Contributor

bors bot commented May 5, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@charleskawczynski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request May 6, 2023
@bors
Try #1229:
aeae60f
@bors
Copy link
Contributor

bors bot commented May 6, 2023

try

Build failed:

@charleskawczynski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request May 6, 2023
@bors
Try #1229:
ad9cba2
@charleskawczynski
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented May 7, 2023

try

Build failed:

@bors
Copy link
Contributor

bors bot commented May 7, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit eeab25d into main May 7, 2023
@bors bors bot deleted the ck/ci_times branch May 7, 2023 01:02
@charleskawczynski charleskawczynski mentioned this pull request May 11, 2023
Merged
bors bot added a commit that referenced this pull request May 11, 2023
@bors @charleskawczynski
Merge #1236
09daec4 
1236: Remove accidentally added flame html file r=charleskawczynski a=charleskawczynski

Added in #1229.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbyrne simonbyrne Awaiting requested review from simonbyrne

@dennisYatunin dennisYatunin Awaiting requested review from dennisYatunin

@sriharshakandala sriharshakandala Awaiting requested review from sriharshakandala

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charleskawczynski