Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply operators byslab, GPU operators #767

Merged
merged 17 commits into from
Feb 24, 2023
Merged

apply operators byslab, GPU operators #767

merged 17 commits into from
Feb 24, 2023

Conversation

simonbyrne
Copy link
Member

@simonbyrne simonbyrne commented Jun 23, 2022

Change how slabs work, implement GPU operators

  • Code follows the style guidelines OR N/A.
  • Unit tests are included OR N/A.
  • Code is exercised in an integration test OR N/A.
  • Documentation has been added/updated OR N/A.

@simonbyrne simonbyrne force-pushed the sb/byslab branch 2 times, most recently from 500a84b to 6304fe5 Compare June 23, 2022 19:17
src/Fields/indices.jl Outdated Show resolved Hide resolved
src/Operators/spectralelement.jl Outdated Show resolved Hide resolved
src/Operators/spectralelement.jl Outdated Show resolved Hide resolved
src/Operators/spectralelement.jl Outdated Show resolved Hide resolved
src/Operators/spectralelement.jl Outdated Show resolved Hide resolved
src/Operators/spectralelement.jl Outdated Show resolved Hide resolved
src/Operators/spectralelement.jl Outdated Show resolved Hide resolved
src/Operators/spectralelement.jl Outdated Show resolved Hide resolved
src/Operators/spectralelement.jl Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/DataLayouts/DataLayouts.jl Outdated Show resolved Hide resolved
src/DataLayouts/DataLayouts.jl Outdated Show resolved Hide resolved
src/DataLayouts/DataLayouts.jl Outdated Show resolved Hide resolved
src/DataLayouts/DataLayouts.jl Outdated Show resolved Hide resolved
src/DataLayouts/DataLayouts.jl Outdated Show resolved Hide resolved
src/Operators/spectralelement.jl Outdated Show resolved Hide resolved
src/Operators/spectralelement.jl Outdated Show resolved Hide resolved
src/Operators/spectralelement.jl Outdated Show resolved Hide resolved
src/Operators/spectralelement.jl Outdated Show resolved Hide resolved
src/Operators/spectralelement.jl Outdated Show resolved Hide resolved
src/Operators/spectralelement.jl Outdated Show resolved Hide resolved
src/Operators/spectralelement.jl Outdated Show resolved Hide resolved
src/Operators/spectralelement.jl Outdated Show resolved Hide resolved
src/Operators/spectralelement.jl Outdated Show resolved Hide resolved
src/Operators/spectralelement.jl Outdated Show resolved Hide resolved
src/Operators/spectralelement.jl Outdated Show resolved Hide resolved
src/Operators/spectralelement.jl Outdated Show resolved Hide resolved
src/Operators/spectralelement.jl Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
@simonbyrne simonbyrne force-pushed the sb/byslab branch 8 times, most recently from f1a01ee to 8cc0def Compare July 2, 2022 18:27
@simonbyrne simonbyrne mentioned this pull request Sep 30, 2022
37 tasks
@simonbyrne simonbyrne force-pushed the sb/byslab branch 2 times, most recently from e28e819 to c780788 Compare January 23, 2023 22:43
@simonbyrne
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jan 23, 2023
@bors
Copy link
Contributor

bors bot commented Jan 23, 2023

try

Build failed:

@simonbyrne
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jan 23, 2023
@bors
Copy link
Contributor

bors bot commented Jan 23, 2023

try

Build failed:

@simonbyrne simonbyrne force-pushed the sb/byslab branch 4 times, most recently from 21bdc33 to 61e5eba Compare January 25, 2023 00:34
@simonbyrne
Copy link
Member Author

bors try

@simonbyrne
Copy link
Member Author

Can we please add a comparison between the CPU and GPU cases for the shallow water test for performance monitoring and potential tuning purposes!

Can be a new issue.

@simonbyrne
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Feb 23, 2023
@bors
Copy link
Contributor

bors bot commented Feb 23, 2023

try

Build failed:

@simonbyrne
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Feb 23, 2023
@bors
Copy link
Contributor

bors bot commented Feb 23, 2023

try

Build failed:

@simonbyrne
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Feb 23, 2023
@simonbyrne
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Feb 24, 2023
767: apply operators byslab, GPU operators r=simonbyrne a=simonbyrne

Change how slabs work, implement GPU operators

- [ ] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A.
- [ ] Unit tests are included OR N/A.
- [ ] Code is exercised in an integration test OR N/A.
- [ ] Documentation has been added/updated OR N/A.


Co-authored-by: Simon Byrne <simonbyrne@gmail.com>
@simonbyrne
Copy link
Member Author

bors r-

@bors
Copy link
Contributor

bors bot commented Feb 24, 2023

Canceled.

@simonbyrne
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Feb 24, 2023
767: apply operators byslab, GPU operators r=simonbyrne a=simonbyrne

Change how slabs work, implement GPU operators

- [ ] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A.
- [ ] Unit tests are included OR N/A.
- [ ] Code is exercised in an integration test OR N/A.
- [ ] Documentation has been added/updated OR N/A.


Co-authored-by: Simon Byrne <simonbyrne@gmail.com>
@bors
Copy link
Contributor

bors bot commented Feb 24, 2023

Build failed:

  • lib-climacore-makie

@simonbyrne
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Feb 24, 2023
767: apply operators byslab, GPU operators r=simonbyrne a=simonbyrne

Change how slabs work, implement GPU operators

- [ ] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A.
- [ ] Unit tests are included OR N/A.
- [ ] Code is exercised in an integration test OR N/A.
- [ ] Documentation has been added/updated OR N/A.


Co-authored-by: Simon Byrne <simonbyrne@gmail.com>
@bors
Copy link
Contributor

bors bot commented Feb 24, 2023

Build failed:

@simonbyrne
Copy link
Member Author

bors r+

@bors bors bot merged commit dcdef25 into main Feb 24, 2023
@bors bors bot deleted the sb/byslab branch February 24, 2023 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spectral element operators
3 participants