Skip to content

Conversation

@iskakaushik
Copy link
Collaborator

Changed verify_ssl_cert default from false to true to protect against man-in-the-middle attacks. Users can still explicitly disable if needed for testing with self-signed certificates.

Fixes #8

Changed verify_ssl_cert default from false to true to protect against
man-in-the-middle attacks. Users can still explicitly disable if needed
for testing with self-signed certificates.

Fixes #8
@iskakaushik iskakaushik requested a review from Copilot October 16, 2025 22:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Enable SSL certificate verification by default to reduce exposure to man-in-the-middle attacks.

  • Changed HttpConfig.verify_ssl_cert default from false to true.
  • No accompanying inline documentation or migration notes added for this behavioral change.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

int connection_timeout_sec = 30;
int read_timeout_sec = 120;
bool verify_ssl_cert = false;
bool verify_ssl_cert = true;
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the default from false to true is a breaking behavioral change for consumers who relied on disabled verification (e.g., self-signed test environments). Consider adding a transitional strategy (e.g., version bump, release notes, or an explicit migration guide) or preserving backward compatibility via a factory/helper that applies legacy defaults when needed.

Copilot uses AI. Check for mistakes.
// "https://openrouter.ai/api")
bool use_ssl = true;
int connection_timeout_sec = 30;
int read_timeout_sec = 120;
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This security-sensitive default merits an explanatory comment (e.g., rationale, how to override for self-signed certificates) above the field to prevent silent confusion. Suggest adding a brief doc comment: // When true, performs SSL certificate validation. Set to false only for controlled test environments with self-signed certs.

Suggested change
int read_timeout_sec = 120;
int read_timeout_sec = 120;
// When true, performs SSL certificate validation. Set to false only for controlled test environments with self-signed certs.

Copilot uses AI. Check for mistakes.
@iskakaushik iskakaushik merged commit 315f17b into main Oct 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing certificate validation check

2 participants