Skip to content

Changed default: enable SSL certificate verification by default #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iskakaushik merged 1 commit into from
Oct 16, 2025
Merged

Changed default: enable SSL certificate verification by default #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/http/http_request_handler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ struct HttpConfig {
bool use_ssl = true;
int connection_timeout_sec = 30;
int read_timeout_sec = 120;
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This security-sensitive default merits an explanatory comment (e.g., rationale, how to override for self-signed certificates) above the field to prevent silent confusion. Suggest adding a brief doc comment: // When true, performs SSL certificate validation. Set to false only for controlled test environments with self-signed certs.

Suggested change
int read_timeout_sec = 120;
int read_timeout_sec = 120;
// When true, performs SSL certificate validation. Set to false only for controlled test environments with self-signed certs.

Copilot uses AI. Check for mistakes.
bool verify_ssl_cert = false;
bool verify_ssl_cert = true;
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the default from false to true is a breaking behavioral change for consumers who relied on disabled verification (e.g., self-signed test environments). Consider adding a transitional strategy (e.g., version bump, release notes, or an explicit migration guide) or preserving backward compatibility via a factory/helper that applies legacy defaults when needed.

Copilot uses AI. Check for mistakes.

// Retry configuration
retry::RetryConfig retry_config;
Expand Down