Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation that samples within a case have the same analysis type #4253

Open
2 tasks
diitaz93 opened this issue Feb 28, 2025 · 1 comment
Open
2 tasks
Labels
technical-debt Complicating development in the repo

Comments

@diitaz93
Copy link
Contributor

diitaz93 commented Feb 28, 2025

As a systems developer,
I want the AnalyisAPI not doing database validations. Specifically, I would like the validation that all samples within a case should have the same AnalysisType done in this method to be implemented in the ordering,
So that we don't need to do database validations in the AnalysisAPI and the separation of concerns is respected.

Work impact

Answer the following questions:

  • Is there currently a workaround for this issue? If so, what is it?
    • No
  • How much time would be saved by implementing this feature on a weekly basis?
    • Nothing
  • How many users are affected by this issue?
    • System developers and Bioinfo developers interacting with the AnalysisAPI
  • Are customers affected by this issue?
    • No

Acceptance Criteria

  • There is a validation rule in the ordering service that verifies that all samples within a case have the same analysis type (i.e. TGS, WES, WGS or WTS) for all pipelines except MIP-DNA
  • The validation in the AnalysisAPI is removed as is no longer needed
    ...

Notes

@diitaz93 diitaz93 changed the title A short, descriptive title. Add validation that samples within a case have the same analysis type Feb 28, 2025
@diitaz93 diitaz93 added the technical-debt Complicating development in the repo label Feb 28, 2025
@islean
Copy link
Contributor

islean commented Mar 5, 2025

Is this not a very weird check to have in the first place

Image

So basically return "wts" if WTS application. If not, return "wgs" if WGS application, and all other applications get the "wes" analysis type? So all applications but WTS and WGS get WES as analysis type?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical-debt Complicating development in the repo
Projects
None yet
Development

No branches or pull requests

2 participants