Fix #5075 - variant filters is redecorated #5076
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5076 +/- ##
==========================================
- Coverage 84.81% 84.80% -0.01%
==========================================
Files 323 323
Lines 19475 19484 +9
==========================================
+ Hits 16517 16524 +7
- Misses 2958 2960 +2 ☔ View full report in Codecov by Sentry. |
| @@ -12,6 +12,8 @@ About changelog [here](https://keepachangelog.com/en/1.0.0/) | |||
| - Panel version check while editing the genes of a panel | |||
| - Display unknown filter tags as "danger" marked badges | |||
| - Open WTS variantS SNVs and SVs in new tabs | |||
| - Variant filters redecoration from multiple classifications crashes general case report | |||
|
|
|||
There was a problem hiding this comment.
Eh, we have always had two lines between the unreleased and released section? I guess we could change that if you like, but... 🤷♂️ Would say prettier have an automated opinion? 😸
There was a problem hiding this comment.
Wasn't it one? That's why I keep fixing the changelogs 😆
Also because there is always one line in between the old releases
There was a problem hiding this comment.
I always remove it for the release branch, but keep it in all the other PRs. 🤷♂️
There was a problem hiding this comment.
We can continue like this: you add the line and I remove it! 🤣
| ) | ||
| for f in map(lambda x: x.lower(), variant_obj["filters"]) | ||
| ] | ||
| variant_filters = variant_obj["filters"] |
There was a problem hiding this comment.
| variant_filters = variant_obj["filters"] | |
| variant_filters = variant_obj.get("filters",[]) |
|
|
||
| filters: List[Dict[str, str]] = [] | ||
|
|
||
| for f in variant_filters: |
There was a problem hiding this comment.
This works, but I like the idea of refactoring because when we have to start having these solutions it means we have some convoluted code before..
There was a problem hiding this comment.
Indeed. It would seem natural to pull the only-show-a-variant-once code in from the template to the controller, and then invoke the variant decorator only once per variant.
There was a problem hiding this comment.
I made an issue so we don't forget: #5078
Co-authored-by: Chiara Rasi <rasi.chiara@gmail.com>
|
This PR adds a functionality or fixes a bug.
Testing on cg-vm1 server (Clinical Genomics Stockholm)
Prepare for testing
scout-stageand the server iscg-vm1.ssh <USER.NAME>@cg-vm1.scilifelab.sesudo -iu hiseq.clinicalssh localhostpodman pssystemctl --user stop scout.targetsystemctl --user start scout@<this_branch>systemctl --user status scout.targetscout-stage) to be used for testing by other users.Testing on hasta server (Clinical Genomics Stockholm)
Prepare for testing
ssh <USER.NAME>@hasta.scilifelab.seus; paxa -u <user> -s hasta -r scout-stage. You can also use the WSGI Pax app available at https://pax.scilifelab.se/.conda activate S_scout; pip freeze | grep scout-browserbash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b <this_branch>us; scout --versionpaxaprocedure, which will release the allocated resource (scout-stage) to be used for testing by other users.How to test:
Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.
Review: