Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button color & Icon color missing for HVAC Dry & Heat/Cool mode in Climate card. #863

Closed
gandhiarpit opened this issue Oct 24, 2024 · 7 comments
Closed

Button color & Icon color missing for HVAC Dry & Heat/Cool mode in Climate card. #863

gandhiarpit opened this issue Oct 24, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@gandhiarpit
Copy link

gandhiarpit commented Oct 24, 2024 •
edited
Loading

Describe the bug
When HVAC Dry mode or Heat/Cool mode is selected in Climate card, it is missing the icon & background color. As seen below

To Reproduce
Steps to reproduce the behavior:

  1. Select Dry mode or Heat/Cool mode in the climate bubble control
  2. HVAC turns ON, but the colors are missing.

Expected behavior
Appropriate different Color should be applied to Icon & Button similar to other modes of HVAC

Screenshots
Bubble_climate_card

Informations (please complete the following information):

  • OS: iOS
  • Browser/App: Chrome/Firefox
  • Bubble Card version: v2.3.0-beta.3
  • Home Assistant version: [e.g. 2024.10.3]

Additional context
Also, for Heat/Cool mode will it change the color depending on if it is heating or cooling? Mushroom card changes the icon based on what HVAC is doing.

Thank you! 🍻
@gandhiarpit gandhiarpit added the bug Something isn't working label Oct 24, 2024
Clooos added a commit that referenced this issue Oct 30, 2024
@Clooos
Climate card fixes + Pop-up fixes + More
a246977 
- [x] Breaking change: Pop-up blurred backdrop disabled by default for performance.
- [x] Fixed the « Large layout 2 rows » in the climate card.
- [x] Fixed? Climate card bug with Bosch BTH-RM230Z #877
- [x] Popup background has an odd black shadow appearing on the top left and top right corners without any reason for it to be there #879
- [x] Fixes missing '•' when state is not shown but Attribute and LastChanged are #872 by @tiagof
- [x] The hold action should now works correctly.
- [x] Smoother and more reliable pop-up animations on some setups.
- [x] The pop-ups should be faster and more reliable overall.
- [x] Only the first letter in the selection list is capitalized #869 and #866
- [x] Fixed? Uncaught (in promise) TypeError: Cannot read properties of null (reading 'classList')
- [x] Fixed some issues with the climate card buttons.
- [x] Fixed climate slider « expected float » error.
- [x] Fan slider not responding #838
- [x] Button color & Icon color missing for HVAC Dry & Heat/Cool mode in Climate card. #863
@gandhiarpit
Copy link
Author

Thanks. I can confirm this works fine now.

@gandhiarpit
Copy link
Author

My initial observation, based on comparing it with Mushroom card. The heat/cool mode on my HVAC changes which mode it is in real time to maintain the target temperature. So it could be either heating or cooling or only fan ON. As you can see in below screenshots, check the mushroom card updating the icon based on what HVAC is doing. Maybe this can be added to bubble climate card? Like update the color of the button to display the mode?

Currently, bubble climate card doesn't tell me what HVAC is doing. But mushroom card tells me either it's cooling or heating or only fan.

Maybe a feature request? This is not a bug, but really good to have for visual confirmation of what HVAC is actually doing.

Bubble climate card

@Clooos
Copy link
Owner

Clooos commented Nov 13, 2024

Hi again, this makes sense, I've changed that behavior so that the color of the card change accordingly 👌

I will release a new beta soon, probably today 🤞

Clooos added a commit that referenced this issue Nov 13, 2024
@Clooos
Climate card new design + various fixes
a8e6bde 
- [x] New more compact design for the climate card, this new design don’t use a sub-button for the temperature anymore. Important: If you’ve added climate cards before, just open these cards one by one in the editor, the previous temperature sub-button will be automatically deleted. Don’t forget to save after that.
- [x] Full support for climate entities with `target_temp_low` and `target_temp_high` #877
- [x] In heat_cool mode, the climate card color now change based on if it’s actually heating or cooling. #863
- [x] Actions are not triggered when scrolling anymore, finally! #892 and #839
- [x] Fixed an issue where it was impossible to scroll anymore in some cases (like in the editor).
- [x] Added the missing bubble-accent-color variable in the media player play/pause button.
- [x] Update climate specific css vars #908 PR from @flobiwankenobi
- [x] New element for pop-up background, breaking change for some users with custom styles. #895
- [x] Underscore removing from list select #890
- [x] Some pop-ups were not displayed displayed correctly, or only when leaving the editor/changing view, this is now fixed! #821
- [x] Fixed some more pop-up issues (like console errors). #840 and #791
- [x] Cover open and close buttons are now disabled when they should. #788
- [x] Slider for controlling thermostat/fan should now works correctly. #849, #838 and #768
@szamfirov
Copy link
Contributor

@Clooos, don't want to raise another issue for something very similar but I just noticed on the latest beta (v2.3.0-beta.8) that when state_color is set to true and you set your entity to heat_cool, this completely breaks the card with an error "Assignment to constant variable". Not sure if it was from the recent state changes but just wanted to surface this here:

Screenshot 2024-11-24 at 20 22 45

It errors out on the "default" case here somewhere. Please let me know if I can provide more details somehow.

@Clooos
Copy link
Owner

Clooos commented Nov 24, 2024

Thanks for the feedback, that was a typo in my code! 😅

Simple fix 👌

@szamfirov
Copy link
Contributor

Good to hear. I just saw it as well - the = instead of === is probably what breaks things :)

@Clooos
Copy link
Owner

Clooos commented Nov 25, 2024

Exactly, just by reading the error you sent I knew it was that before looking at my code 😄

@Clooos Clooos closed this as completed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@szamfirov @gandhiarpit @Clooos and others