fix pktdev_close to release internal lport data #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeithWiles
force-pushed
the
port_close_fix
branch
2 times, most recently
from
5bd38c2
to
c5e38d6
Compare
KeithWiles
force-pushed
the
port_close_fix
branch
from
c5e38d6
to
d338843
Compare
When pktdev_close() was called the code would close the lport but it needed to release the lport by calling pktdev_release_port(). Cleanup the a PMD probe and remove routines. In the probe routine we now store the struct pktdev_driver pointer in the struct cne_pktdev structure to allow for a cleaner remove or close of an lport. Remove pktdev_create_done() routine and move the logic into the pktdev_port_setup() routine. This would allow the Go code to be able to cleanup correctly and the PMDs were checking if dev == NULL before calling pktdev_release_port() which is not required. Remove the PKTDEV_LOG() macro and use CNE_XXX macros instead. Signed-off-by: Keith Wiles <keith.wiles@intel.com>
KeithWiles
force-pushed
the
port_close_fix
branch
from
d338843
to
afcbc58
Compare
jeffreybshaw
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pktdev_close() was called the code would close the lport
but it needed to release the lport by calling pktdev_release_port().
Cleanup the a PMD probe and remove routines. In the probe routine we
now store the struct pktdev_driver pointer in the struct cne_pktdev structure
to allow for a cleaner remove or close of an lport. Remove pktdev_create_done()
routine and move the logic into the pktdev_port_setup() routine.
This would allow the Go code to be able to cleanup correctly and the PMDs
were checking if dev == NULL before calling pktdev_release_port() which is
not required.
Remove the PKTDEV_LOG() macro and use CNE_XXX macros instead.
Signed-off-by: Keith Wiles keith.wiles@intel.com