-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go binding cleanup and example app #154
Go binding cleanup and example app #154
Conversation
31ee733
to
85d02f7
Compare
The super linter is executing on the XXX_test.go files and it should not unless we can figure out how to make it work. I do not think is a big problem, so I would like to figure out how to exclude *_test.go files. The next problem is the Super-Linter does not appear to understand import "C" statements and that causes a number of failures. |
This PR needs #153 to be complete, but I could not find how to make this PR dependent on PR 153. |
85d02f7
to
5514f8f
Compare
setting VALIDATE_GO: false https://github.com/CloudNativeDataPlane/cndp/blob/main/.github/workflows/super-linter.yml#L33 would prevent Go files from being linted These issues seem to be related to the failures shown by the Go linter
https://github.com/github/super-linter/issues/1599 - related to the the undeclared name failure |
5514f8f
to
ef51054
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a start....
got as far as lport_test.go (will keep tipping away at it)
ef51054
to
05f0504
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got as far as the examples dir - will try to close off the rest tomorrow
Here is a list on what I cleaned up (not a complete list): - Simplify the usability and utilize the full JSON-c configuration. - Remove some files that are combined into others and rework a few areas to make it easier to understand. - Rework RxBurst/TxBurst/… to take a lportID instead of passing a method pointer. - Cleaned up a number of allocations around LPort as this data is static after startup. - Remove all of the underscore variables and convert them to Go variable names. - Add the start of documentation to all of the files. Needs more work. - Added a few more helper routines to parse a slice to packets or objects. - Update the example/fwd application to utilize the JSON-c instead of JSON - Remove the -port option and use the JSON-c thread section to identify the lports attached to a given thread - Add support for using the JSON Threads section for starting threads an assigning lports to those threads. - Use the tview Go library to display the stats in a easier to read format. - Update the test routines to poll more than just one lport. - Updated the cne/run_test code and script to test more functions. - Updated the example/run_fwd script remove the -port option with other cleanups. - Fix the tx only packet format as it was missing part of the packet data - More minor changes for refactoring and cleanup. Signed-off-by: Keith Wiles <keith.wiles@intel.com>
1f92945
to
bfc7bae
Compare
Are we all done reviewing this one? Thank you for the reviews. |
If @maryamtahhan approves, let's merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the delay. LGTM
Here is a list on what I cleaned up:
Signed-off-by: Keith Wiles keith.wiles@intel.com