Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fyi #60

Closed
wants to merge 2 commits into from
Closed

fyi #60

wants to merge 2 commits into from

Conversation

zswgzx
Copy link

@zswgzx zswgzx commented May 17, 2021

draft PR as requested.

working on first_level() but it runs long in my desktop, so unable to proceed for verification. secondlevel() is untouched.

@gdevenyi
Copy link
Member

working on first_level() but it runs long in my desktop
Downsample your inputs to 4x4x4mm to run faster.

@gdevenyi
Copy link
Member

As per my request at #59 (comment)

I can't accept contributions without clear separated commits documenting each change in a way where they are reviewable. Please investigate using git add -p to separate out into coherent changes.

@zswgzx
Copy link
Author

zswgzx commented May 17, 2021

you mean one change at a time?
will take me long to commit every single change, since the original code was, to my best experience, with all respect, written in a way that I feel extremely difficult to follow (hopefully not by intension).
Refactoring it took me the full past Sunday and I still haven't done with secondlevel() yet.
I'd suggest a pro programmer to do so if required. Sorry about that. Appreciate your time and effort.

@zswgzx
Copy link
Author

zswgzx commented May 17, 2021

I'll try the down sampled images as suggested.
My goal is to achieve exactly the same outputs using the original and my edited codes, and I'll still work on it.
My lab has no clusters with slurm so I wonder if you'd be able to test, but I'm afraid I couldn't invest too much time on this any longer. I'd be happy to know any update from now on. Thank you.

@zswgzx zswgzx closed this May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants