Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved warning message for DSL attribute renaming #327

Merged
merged 1 commit into from
May 17, 2016
Merged

Improved warning message for DSL attribute renaming #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@

##### Enhancements

* None.
* Improved warning message for the renaming of `xcodeproj` to `project` in the `Podfile` DSL.
[Olivier Halligon](https://github.com/AliSoftware)
[#327](https://github.com/CocoaPods/Core/pull/327)

##### Bug Fixes

Expand Down
2 changes: 1 addition & 1 deletion lib/cocoapods-core/podfile/dsl.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,7 @@ def project(path, build_configurations = {})
# For pre-1.0 versions use `xcodeproj`.
#
def xcodeproj(*args)
CoreUI.warn 'xcodeproj was renamed to `project`. Please use that from now on.'
CoreUI.warn '`xcodeproj` was renamed to `project`. Please update your Podfile accordingly.'
project(*args)
end

Expand Down
2 changes: 1 addition & 1 deletion spec/podfile/dsl_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@ module Pod
podfile = Podfile.new { xcodeproj 'App.xcodeproj', 'Test' => :debug }
podfile.target_definitions['Pods'].user_project_path.should == 'App.xcodeproj'
podfile.target_definitions['Pods'].build_configurations.should == { 'Test' => :debug }
CoreUI.warnings.should == 'xcodeproj was renamed to `project`. Please use that from now on.'
CoreUI.warnings.should == '`xcodeproj` was renamed to `project`. Please update your Podfile accordingly.'
end
end

Expand Down