Improved warning message for DSL attribute renaming #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliSoftware
force-pushed
the
dsl_better_warning
branch
from
ed1aaa7 to
1717717
Compare
AliSoftware
force-pushed
the
dsl_better_warning
branch
from
1717717 to
2c92be2
Compare
|
👍 yep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of my coworkers and friends saw the "xcodeproj was renamed to project" warning but thought it was a warning inside CocoaPods' own code, like some warning aimed at us and that we'd have to fix in the future.
They didn't understand that it was meant to suggest that they should update their
Podfileto fix it. Hence that new message to make things clearer.