Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache target definition label value #387

Merged
merged 1 commit into from
Jun 20, 2017
Merged

Cache target definition label value #387

merged 1 commit into from
Jun 20, 2017

Conversation

dnkoutso
Copy link
Contributor

@dnkoutso dnkoutso commented Jun 19, 2017 •
edited
Loading

See CocoaPods/CocoaPods#6810 for profiling and why this helps!

@dnkoutso dnkoutso force-pushed the target_definition_label_performance branch 2 times, most recently from c041f93 to 4b2d244 Compare June 19, 2017 04:37
dnkoutso
dnkoutso commented Jun 19, 2017
View reviewed changes
lib/cocoapods-core/podfile/target_definition.rb
else
"#{parent.label}-#{name}"
end
@label ||= if root? && name == 'Pods'
Copy link
Contributor Author

@dnkoutso dnkoutso Jun 19, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubocop styling. ¯\_(ツ)_/¯

@dnkoutso dnkoutso mentioned this pull request Jun 19, 2017
Closed
@dnkoutso dnkoutso requested a review from endocrimes June 19, 2017 05:57
@dnkoutso
Copy link
Contributor Author

Rebased

@dnkoutso dnkoutso force-pushed the target_definition_label_performance branch from 4b2d244 to a37c66f Compare June 20, 2017 16:09
@segiddins
Copy link
Member

👍 if you invalidate when the name is set

@dnkoutso dnkoutso force-pushed the target_definition_label_performance branch from a37c66f to 3149f95 Compare June 20, 2017 16:34
@dnkoutso
Copy link
Contributor Author

done. does it look right?

@segiddins
Copy link
Member

💯

endocrimes
endocrimes approved these changes Jun 20, 2017
View reviewed changes
Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 💯

@dnkoutso dnkoutso force-pushed the target_definition_label_performance branch from 3149f95 to f5b34bc Compare June 20, 2017 16:52
@dnkoutso dnkoutso merged commit a722eef into CocoaPods:master Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endocrimes endocrimes endocrimes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnkoutso @segiddins @endocrimes