feat: add validationSchemaExportType to config w/ resolve deps
#389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as const
|
@elijaholmos Thank you! |
|
@Code-Hex this is awesome! thank you so much for this hard work that will surely introduce much expandability in the future! |
tobiasdiez
reviewed
Jul 6, 2023
| export function EventInputSchema(): z.ZodObject<Properties<EventInput>> { | ||
| return z.object<Properties<EventInput>>({ | ||
| arguments: z.array(z.lazy(() => EventArgumentInputSchema())), | ||
| export const EventInputSchema: z.ZodObject<Properties<EventInput>> = z.object({ |
There was a problem hiding this comment.
is there a reason why this is no longer passing Properties<EventInput> to z.object?
I now get errors of the form
Type 'ZodObject<{ deviceName: ZodEffects<ZodAny, any, any>; filePath: ZodEffects<ZodAny, any, any>; }, "strip", ZodTypeAny, { deviceName?: any; filePath?: any; }, { ...; }>' is not assignable to type 'ZodObject<Required<{ deviceName: ZodType<string, any, string>; filePath: ZodType<string, any, string>; }>, UnknownKeysParam, ZodTypeAny, { ...; }, { ...; }>'.
Type '{ deviceName?: any; filePath?: any; }' is not assignable to type '{ deviceName: string; filePath: string; }'.
which are fixed if I provide the correct type to object.
51 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #382 (comment)
I've added logic to graph the dependencies that GraphQL schemas have, and perform a topological sort based on that in order to resolve the dependencies. Normally, this sort is effective when there are no circular references, but I have made some modifications because users may generate code from schemas that have circular references.