Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Notify the user when an error is encountered when adding new accounts #1252

Closed
Cubik65536 opened this issue Apr 30, 2023 · 1 comment · Fixed by #1253
Closed

✨ Notify the user when an error is encountered when adding new accounts #1252

Cubik65536 opened this issue Apr 30, 2023 · 1 comment · Fixed by #1253
Labels
enhancement New feature or request

Comments

@Cubik65536
Copy link
Contributor

Description

Currently, when the user add a new account (GitHub, GitLab, etc.) and there's an error (duplicated account, auth failed, etc.), CodeEdit won't notify the user (we just have a print for now). In this case, the user might think that the app is not responding. So we should notify user for it.

Alternatives Considered

No response

Additional Context

For now, I tend to use alert for showing the notification. Don't know if there's a better solution for this kind of popup notification.

Screenshots

No response
@Cubik65536 Cubik65536 added the enhancement New feature or request label Apr 30, 2023
@austincondiff
Copy link
Collaborator

We should also account for network request failures as well.

@Cubik65536 Cubik65536 mentioned this issue Apr 30, 2023
Merged
13 tasks
@github-project-automation github-project-automation bot moved this from 🆕 New to 🏁 Complete in CodeEdit Project May 6, 2023
austincondiff pushed a commit that referenced this issue May 6, 2023
@Cubik65536
feat: Notify the user when an error is encountered when adding new ac…
aaae8a9 
…counts (#1252) (#1253)

* refactor: Replace all `GitURL` with url in `SourceControlAccount`

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>

* style: Remove Trailing Whitespace

* refactor(AccountsSettingsSigninView): Move duplicate account check before sign in

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>

* feat(AccountsSettingsSigninView): Add Alert when adding duplicate account

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>

* feat: Alert the user when error occurs during account sign-in

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>

* fix: Fix possible `nil` url for BitBucketTokenConfiguration

* style: Remove Trailing Whitespace

---------

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
CodeEdit Project
Status: 🏁 Complete
Milestone
No milestone
2 participants
@austincondiff @Cubik65536