-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Notify the user when an error is encountered when adding new accounts (#1252) #1253
Merged
austincondiff
merged 8 commits into
CodeEditApp:main
from
Cubik65536:add-account-error-alert
May 6, 2023
Merged
feat: Notify the user when an error is encountered when adding new accounts (#1252) #1253
austincondiff
merged 8 commits into
CodeEditApp:main
from
Cubik65536:add-account-error-alert
May 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qian Qian "Cubik" <cubik65536@cubik65536.top>
…fore sign in Signed-off-by: Qian Qian "Cubik" <cubik65536@cubik65536.top>
…ount Signed-off-by: Qian Qian "Cubik" <cubik65536@cubik65536.top>
Signed-off-by: Qian Qian "Cubik" <cubik65536@cubik65536.top>
matthijseikelenboom
requested review from
austincondiff,
0xWDG,
matthijseikelenboom,
lukepistrol,
thecoolwinter,
Wouter01 and
KaiTheRedNinja
May 5, 2023 09:29
0xWDG
previously approved these changes
May 5, 2023
It looks like there is a SwiftLint error. Please resolve. |
fixed |
austincondiff
approved these changes
May 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
KaiTheRedNinja
approved these changes
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GitURL.baseURL
withSourceControlAccount.Provider.apiURL
andGitURL.webURL
withSourceControlAccount.Provider.baseURL
to prevent confusion between usage of these URLs.Related Issues
Checklist
Screenshots
Video Demo:
2023-05-01.00-22-11.mov