Message Preview when opening the non coding file #102

nanashili · 2022-03-19T18:30:11Z

The current message that shows is not really informative when trying to open unsupported files in the editor. Updated it to give the user more of an idea of why it can't be opened. We should maybe show a popup in the future to that suggest this instead of an empty view.

But once we have extensions going we can prompt the user to install an extension that could help with this.

This reverts commit 8139217.

This reverts commit 78b748b.

…iles that are not code related

0xWDG

Don’t forget the translation 😊

0xWDG · 2022-03-19T18:32:33Z

CodeEdit/SideBar/SideBarItem.swift

@@ -40,7 +40,7 @@ struct SideBarItem: View {
                            }
                        }
                } else {
-                    Text("File cannot be opened")
+                    Text("CodeEditor can currently not open this file type.")


Don’t forget to add it to the translations 😊

…kaans Language

nanashili · 2022-03-19T18:47:10Z

Don’t forget the translation 😊

Added the translations and added support for an additional language.

CodeEdit/Localization/be.lproj/Localizable.strings

CodeEdit/Localization/ru.lproj/Localizable.strings

nanashili · 2022-03-19T19:04:07Z

Updated with suggested changes!

austincondiff

I'd recommend that grammatical change. No need to use "currently". Keep it short and sweet. You may need to retranslate.

austincondiff · 2022-03-19T19:33:55Z

CodeEdit/Localization/be.lproj/Localizable.strings

@@ -39,3 +39,6 @@
 // Welcome Screen - Workspaces
 "Open a project or file"="Адкрыйце праект або файл";
 "Open an existing project or file on your Mac"="Адкрыйце існуючы праект або файл на вашым Mac";
+
+//Editor Screen
+"CodeEditor can currently not open this file type." = "Зараз CodeEditor не можа адкрыць файл гэтага тыпу.";


Suggested change

"CodeEditor can currently not open this file type." = "Зараз CodeEditor не можа адкрыць файл гэтага тыпу.";

"CodeEdit cannot open this file type." = "Зараз CodeEditor не можа адкрыць файл гэтага тыпу.";

Cannot is not something you want to say, whereas 'can currently not' suggests that it will eventually support the file type preview if it makes sense?

"can currently not" does not make grammatical sense in English, it would instead be "currently cannot". I don't know if we want to imply that we will one day support file types that we might never support.

Make sense... Idk our English is very different from most countries. But makes sense and I get you. The requested changes were made

Also, technically we are opening a file of that specific file type rather than opening the file type itself. So it might say something like "CodeEdit cannot open this file because it's file type is not supported."

austincondiff · 2022-03-19T19:33:59Z

CodeEdit/Localization/de.lproj/Localizable.strings

@@ -39,3 +39,6 @@
 // Welcome Screen - Workspaces
 "Open an existing project or file on your Mac"="Vorhandenes Projekt oder Datei auf Mac öffnen";
 "Show this window when CodeEdit launches"="Zeigen wenn CodeEdit geöffnet wird";
+
+//Editor Screen
+"CodeEditor can currently not open this file type." = "CodeEditor kann diesen Dateityp derzeit nicht öffnen.";


Suggested change

"CodeEditor can currently not open this file type." = "CodeEditor kann diesen Dateityp derzeit nicht öffnen.";

"CodeEdit cannot open this file type." = "CodeEditor kann diesen Dateityp derzeit nicht öffnen.";

austincondiff · 2022-03-19T19:34:03Z

CodeEdit/Localization/en.lproj/Localizable.strings

@@ -39,3 +39,6 @@
 // Welcome Screen - Workspaces
 "Open an existing project or file on your Mac"="Open an existing project or file on your Mac";
 "Show this window when CodeEdit launches"="Show this window when CodeEdit launches";
+
+//Editor Screen
+"CodeEditor can currently not open this file type." = "CodeEditor can currently not open this file type.";


Suggested change

"CodeEditor can currently not open this file type." = "CodeEditor can currently not open this file type.";

"CodeEdit cannot open this file type." = "CodeEdit cannot open this file type.";

austincondiff · 2022-03-19T19:34:21Z

CodeEdit/Localization/ru.lproj/Localizable.strings

@@ -39,3 +39,6 @@
 // Welcome Screen - Workspaces
 "Open a project or file"="Откройте проект или файл";
 "Open an existing project or file on your Mac"="Откройте существующий проект или файл на вашем Mac";
+
+//Editor Screen
+"CodeEditor can currently not open this file type." = "Сейчас CodeEditor не может открыть файл этого типа.";


Suggested change

"CodeEditor can currently not open this file type." = "Сейчас CodeEditor не может открыть файл этого типа.";

"CodeEdit cannot open this file type." = "Сейчас CodeEditor не может открыть файл этого типа.";

austincondiff · 2022-03-19T19:35:13Z

CodeEdit/Localization/af.lproj/Localizable.strings

+"Show this window when CodeEdit launches"="Wys hierdie venster wanneer CodeEdit begin";
+
+//Editor Screen
+"CodeEditor can currently not open this file type." = "CodeEditor kan tans nie hierdie lêertipe oopmaak nie.";


Suggested change

"CodeEditor can currently not open this file type." = "CodeEditor kan tans nie hierdie lêertipe oopmaak nie.";

"CodeEdit cannot open this file type." = "CodeEditor kan tans nie hierdie lêertipe oopmaak nie.";

* Cleaned up the typography for Welcome Screen * Added support for more code editor themes * Revert "Added support for more code editor themes" This reverts commit 8139217. * Revert "Cleaned up the typography for Welcome Screen" This reverts commit 78b748b. * Update the error message to be more informative when trying to open files that are not code related * Added language translations for editor error and support for the Afrikaans Language * Fixed localization changes in Russian and Belarusian * Updated the editor error string to be short and sweet * Update to editor error for file types.

* Improved overall tab style to feel more native to macOS * Fixed lint error * More lint error fixes * More lint error fixes * More liner error fixes * Create CONTRIBUTING.md * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Fix "Welcome to CodeEdit" Main Menu item (#106) * Fix data format (#105) * Allow opening of `public.item` instead of `public.source-code` * Handle errors * Message Preview when opening the non coding file (#102) * Cleaned up the typography for Welcome Screen * Added support for more code editor themes * Revert "Added support for more code editor themes" This reverts commit 8139217. * Revert "Cleaned up the typography for Welcome Screen" This reverts commit 78b748b. * Update the error message to be more informative when trying to open files that are not code related * Added language translations for editor error and support for the Afrikaans Language * Fixed localization changes in Russian and Belarusian * Updated the editor error string to be short and sweet * Update to editor error for file types. * Change document types priority, prioritize workspace over source code file to fix #110 * Fix multiple welcome window * Fix version localization key (#120) * Improved overall tab style to feel more native to macOS * Fixed lint error * More lint error fixes * Replicating aesthetic and behavior of standard tabs. Removed wrapper component so that code is more straightforward. * Update WorkspaceCodeFileView.swift Resolved conflicts * Fixed lint errors and animations * Added PressActionsModifier file to project * Added PressActionsModifier.swift * Fixed lint error * Fixed lint error Co-authored-by: Luke <lukas@pistrol.com> Co-authored-by: Pavel Kasila <pavel.kasila@gmail.com> Co-authored-by: Nanashi Li <tihan-nico@plexus.dev> Co-authored-by: Ziyuan Zhao <ninjiacoder@gmail.com>

nanashili added 11 commits March 19, 2022 12:23

Cleaned up the typography for Welcome Screen

78b748b

Merge branch 'CodeEditApp:main' into main

cc62c96

Merge branch 'CodeEditApp:main' into main

5287e33

Added support for more code editor themes

8139217

Merge branch 'CodeEditApp:main' into main

39c34a5

Revert "Added support for more code editor themes"

537d128

This reverts commit 8139217.

Merge branch 'main' of https://github.com/nanashili/CodeEdit

30d1b99

Revert "Cleaned up the typography for Welcome Screen"

0e0a63a

This reverts commit 78b748b.

Merge branch 'CodeEditApp:main' into main

4eb7309

Merge branch 'CodeEditApp:main' into main

06c3deb

Update the error message to be more informative when trying to open f…

4617144

…iles that are not code related

0xWDG reviewed Mar 19, 2022

View reviewed changes

Added language translations for editor error and support for the Afri…

15865fd

…kaans Language

pkasila reviewed Mar 19, 2022

View reviewed changes

CodeEdit/Localization/be.lproj/Localizable.strings Outdated Show resolved Hide resolved

pkasila reviewed Mar 19, 2022

View reviewed changes

CodeEdit/Localization/ru.lproj/Localizable.strings Outdated Show resolved Hide resolved

Fixed localization changes in Russian and Belarusian

8b901fb

austincondiff requested changes Mar 19, 2022

View reviewed changes

Updated the editor error string to be short and sweet

9cd16af

nanashili requested review from austincondiff and pkasila March 19, 2022 19:45

pkasila approved these changes Mar 19, 2022

View reviewed changes

Update to editor error for file types.

2b0dbfc

austincondiff approved these changes Mar 19, 2022

View reviewed changes

austincondiff merged commit 1c3132e into CodeEditApp:main Mar 19, 2022

xinix909 pushed a commit to xinix909/CodeTransfer that referenced this pull request Sep 7, 2024

Fix for non-updating text (CodeEditApp#102)

f7883bb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Message Preview when opening the non coding file #102

Message Preview when opening the non coding file #102

nanashili commented Mar 19, 2022

0xWDG left a comment

0xWDG Mar 19, 2022

nanashili commented Mar 19, 2022

nanashili commented Mar 19, 2022

austincondiff left a comment

austincondiff Mar 19, 2022

nanashili Mar 19, 2022

austincondiff Mar 19, 2022

nanashili Mar 19, 2022

austincondiff Mar 19, 2022

austincondiff Mar 19, 2022

austincondiff Mar 19, 2022

austincondiff Mar 19, 2022

austincondiff Mar 19, 2022

	"CodeEditor can currently not open this file type." = "Зараз CodeEditor не можа адкрыць файл гэтага тыпу.";
	"CodeEdit cannot open this file type." = "Зараз CodeEditor не можа адкрыць файл гэтага тыпу.";

Message Preview when opening the non coding file #102

Message Preview when opening the non coding file #102

Conversation

nanashili commented Mar 19, 2022

0xWDG left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nanashili commented Mar 19, 2022

nanashili commented Mar 19, 2022

austincondiff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment