Tab Improvements #128
Merged
Tab Improvements #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow opening of `public.item` instead of `public.source-code` * Handle errors
* Cleaned up the typography for Welcome Screen * Added support for more code editor themes * Revert "Added support for more code editor themes" This reverts commit 8139217. * Revert "Cleaned up the typography for Welcome Screen" This reverts commit 78b748b. * Update the error message to be more informative when trying to open files that are not code related * Added language translations for editor error and support for the Afrikaans Language * Fixed localization changes in Russian and Belarusian * Updated the editor error string to be short and sweet * Update to editor error for file types.
…component so that code is more straightforward.
Conflicts: CodeEdit.xcodeproj/project.pbxproj CodeEdit/AppDelegate.swift CodeEdit/Documents/WorkspaceDocument.swift CodeEdit/Rows/FileTabRow.swift CodeEdit/SideBar/SideBarItem.swift CodeEdit/TabBar/TabBar.swift CodeEdit/TabBar/TabBarItem.swift
Resolved conflicts
xinix909
pushed a commit
to xinix909/CodeTransfer
that referenced
this pull request
Sep 7, 2024
<!--- IMPORTANT: If this PR addresses multiple unrelated issues, it will be closed until separated. --> ### Description 1. Add 20 pixels of inset to the left of the ruler and 8 pixels of inset to the right of the ruler. I tried to match it as close as possible to Xcode. 2. Set the background color of the highlight ruler line to the same color as the highlighted line in the textView. ### Related Issues <!--- REQUIRED: Tag all related issues (e.g. * CodeEditApp#123) --> <!--- If this PR resolves the issue please specify (e.g. * closes CodeEditApp#123) --> <!--- If this PR addresses multiple issues, these issues must be related to one other --> * closes CodeEditApp#156 * closes CodeEditApp#128 ### Checklist <!--- Add things that are not yet implemented above --> - [x] I read and understood the [contributing guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md) as well as the [code of conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md) - [x] The issues this PR addresses are related to each other - [x] My changes generate no new warnings - [x] My code builds and runs on my machine - [x] My changes are all related to the related issue above - [x] I documented my code ### Screenshots <!--- REQUIRED: if issue is UI related --> <img width="765" alt="Screenshot 2023-03-16 at 19 05 59" src="https://user-images.githubusercontent.com/82230675/225717006-40530a7b-7864-404b-8d14-5307f6f83bdb.png"> <!--- IMPORTANT: Fill out all required fields. Otherwise we might close this PR temporarily -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2022-03-20.at.5.59.27.PM.mp4
Replicating aesthetic and behavior of standard tabs. Removed wrapper component so that code is more straightforward.
Incorporated changes made by @viktorstrate in #126.