Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Tabs #126

Closed
wants to merge 3 commits into from
Closed

Conversation

viktorstrate
Copy link

Move Button wrapper around each item in TabBar into TabBarItems, since that's semantically more correct.
I don't see a case where we would have a tab bar that was not also a button?

Add context menu to TabBarItems with options to Close Tab, Close Other Tabs, Close Tabs to the Right.

Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, however I am going to pull in some of these change into my own branch and closing this one. I have been working on an overhaul of the tab component and will incorporate menu items and keyboard shortcuts.

@viktorstrate
Copy link
Author

Thank you, I'm excited to see where this project goes.

@austincondiff austincondiff mentioned this pull request Mar 20, 2022
@viktorstrate viktorstrate deleted the improve-tabs branch June 4, 2022 17:18
xinix909 pushed a commit to xinix909/CodeTransfer that referenced this pull request Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants