fix(#1557): autosave #1577
fix(#1557): autosave #1577
Conversation
|
This looks great, just make sure if the user disables autosave in Settings it works as expected. |
- When the user changes the autosave setting from off to on, it will save the previous changes. - The user discarded change, but the editor didn't update.
|
It should work as expected now. Autosave OnScreen.recording.2024-01-28.am.12.34.22.movAutosave OffScreen.recording.2024-01-28.am.12.31.23.mov |
austincondiff
requested review from
matthijseikelenboom,
FastestMolasses,
thecoolwinter,
tom-ludwig and
austincondiff
There was a problem hiding this comment.
Looks good to me. Thanks for your work.
It closes #1557, doesn't it?
|
Oh just ran into a glitch: If I edit a doc with auto-save off, then switch auto-save back on, the changed file indicator sticks around. It's not behaving as expected. @austincondiff, should I go ahead and merge this PR? It technically addresses the auto-save issue. Screen.Recording.2024-01-28.at.11.00.13.AM.mov |
tom-ludwig
dismissed
their stale review
I have noticed a problem and am waiting for Austin's approval.
|
It seems that you are turning auto save on with an unsaved file open. If it has been saved and it is turned on does it work as expected? In this case we need to merge this PR and open a subsequent issue addressing the enabling of auto save while an unsaved file is open. What is the expected behavior when this happens? Should it save all unsaved files? Should we wait to save an unsaved file after the first modification? Should we wait to save after the first manual save then auto save works normally for that file? |
|
Yeah, saving first and turning auto-save back on works fine, so let's go ahead and merge. Regarding the other questions, I'm currently uncertain. Let's discuss those matters in detail within the issue once it's created |
Description
When making changes to a file and having autosave enabled, the edits will be saved.
Related Issues
Checklist
Screenshots