Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1557): autosave #1577

Merged
merged 2 commits into from
Jan 28, 2024
Merged

fix(#1557): autosave #1577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfc6843
fix: autosave
ElvisWong213 Jan 27, 2024
c375540
fix: autosave behaves
ElvisWong213 Jan 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CodeEdit/Features/CodeFile/CodeFileView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ struct CodeFileView: View {
scheduler: DispatchQueue.main
)
.sink { _ in
codeFile.updateChangeCount(.changeDone)
codeFile.autosave(withImplicitCancellability: false) { _ in
}
}
Expand Down
9 changes: 4 additions & 5 deletions CodeEdit/Features/Editor/Models/Editor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,11 +107,6 @@ final class Editor: ObservableObject, Identifiable {

if temporaryTab?.file == file {
temporaryTab = nil
} else {
// When tab actually closed (not changed from temporary to normal)
// we need to set fileDocument to nil, otherwise it will keep file in memory
// and not reload content on next openTabFile with same id
file.fileDocument = nil
}

historyOffset = 0
Expand All @@ -122,6 +117,10 @@ final class Editor: ObservableObject, Identifiable {
if let selectedTab {
history.prepend(selectedTab)
}
// Reset change count to 0
file.fileDocument?.updateChangeCount(.changeCleared)
// remove file from memory
file.fileDocument = nil
}

/// Closes the currently opened tab in the tab group.
Expand Down
Loading